doc: Note that generateblock does not collect transaction fees #34891

pull HouseOfHufflepuff wants to merge 1 commits into bitcoin:master from HouseOfHufflepuff:doc-generateblock-fees changing 1 files +2 −1

HouseOfHufflepuff commented at 12:11 AM on March 22, 2026: contributor
Summary
- Add a note to the generateblock RPC help text clarifying that transaction fees are not collected in the block reward
- This was suggested by maflcko in #31684 as a minimal doc fix
refs #31684

Test plan
- ./build/bin/test_bitcoin --run_test=rpc_tests passes
- cmake --build build --target bitcoind compiles cleanly

doc: Note that generateblock does not collect transaction fees

The generateblock RPC creates blocks where the coinbase only includes
the block subsidy, omitting transaction fees. Document this behavior
in the RPC help text to avoid confusion.

refs #31684

3136559923

DrahtBot added the label Docs on Mar 22, 2026
DrahtBot commented at 12:11 AM on March 22, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, sedited

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #34049 (rpc: Disallow captures in RPCMethodImpl by ajtowns)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
HouseOfHufflepuff commented at 12:11 AM on March 22, 2026: contributor

@maflcko
maflcko commented at 4:43 PM on March 24, 2026: member

lgtm ACK 313655992358e426120a1f902e18161c09ca942f
sedited approved
sedited commented at 8:16 PM on March 24, 2026: contributor

ACK 313655992358e426120a1f902e18161c09ca942f
sedited merged this on Mar 24, 2026
sedited closed this on Mar 24, 2026

Type	Reviewers
ACK	maflcko, sedited

Contributors

Labels

Linked (view graph)

#31684 `generateblock` RPC Not Collecting Transaction Fees

doc: Note that generateblock does not collect transaction fees #34891

Summary

Test plan

Reviews

Conflicts