better std::exception logging for block/undo files #3490

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:exception_logging changing 2 files +13 −13

Diapolo commented at 2:14 PM on January 6, 2014: none

No description provided.
better std::exception logging for block/undo files 7e08e29117
BitcoinPullTester commented at 2:48 PM on January 6, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7e08e29117546aae66b0b418b2044f77b70b312f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 2:46 PM on January 17, 2014: none

@sipa Mind merging this one, it's similar to the change in txdb.cpp a few days ago.
sipa commented at 5:42 PM on January 17, 2014: member

ACK, though I prefer being consistent, and using "error...: message" rather than "error - message".
Diapolo commented at 6:46 PM on January 17, 2014: none

I'm not sure I understand your comment, this is from txdb.cpp and seems rather similar (better identical): error("%s : Deserialize or I/O error - %s", __PRETTY_FUNCTION__, e.what());.
sipa commented at 6:58 PM on January 17, 2014: member

Apologies, I didn't check and misremembered. ACK.
jgarzik commented at 7:03 PM on January 17, 2014: contributor

ACK
laanwj referenced this in commit 6c19ca1f92 on Jan 18, 2014
laanwj merged this on Jan 18, 2014
laanwj closed this on Jan 18, 2014
Diapolo deleted the branch on Jan 18, 2014
DrahtBot locked this on Sep 8, 2021

Contributors