Add ‘opnet’ to datacarriersize #34904
pull marathon2888 wants to merge 1 commits into bitcoin:master from marathon2888:opnet-core changing 4 files +271 −0-
marathon2888 commented at 5:45 pm on March 23, 2026: noneThis policy filter is capable of filtering all types of ‘opnet’ transactions.
-
Add 'opnet' to datacarriersize 8f1d5a348c
-
DrahtBot commented at 5:45 pm on March 23, 2026: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
Type Reviewers Concept NACK kevkevinpal If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
LLM Linter (✨ experimental)
Possible places where comparison-specific test macros should replace generic comparisons:
- [test/functional/mempool_reject_opnet.py]
assert magic_offset > 0, f"magic should be at non-zero offset, got {magic_offset}"-> Useassert_greater_than(magic_offset, 0)(optionally keep the f-string as the assertion message if supported). - [test/functional/mempool_reject_opnet.py]
assert magic_offset > 0, f"magic should be at non-zero offset, got {magic_offset}"-> Useassert_greater_than(magic_offset, 0). - [test/functional/mempool_reject_opnet.py]
assert result['reject-reason'] != 'tokens-op-net', f"Node 1 should not reject as token, got: {result['reject-reason']}"-> Useassert_not_equal(result['reject-reason'], 'tokens-op-net')(optionally preserve the message).
2026-03-23 17:45:37
- [test/functional/mempool_reject_opnet.py]
-
kevkevinpal commented at 6:28 pm on March 23, 2026: contributor
Concept NACK
What is OP_NET?
Can you provide links or documentation? Why would Bitcoin Core want to filter these transactions?
From what I’ve looked up, Opnet is another protocol, it does not make sense to add code to Bitcoin Core specifically for other projects
-
pinheadmz commented at 6:36 pm on March 23, 2026: memberThis should be posted on the bitcoin-dev mailing list, the Delving Bitcoin forum or some other platform where broad, protocol-level concepts are discussed. Conceptual questions and most usage questions can be posted on Stack Exchange. The Bitcoin Core issue tracker is reserved for discussion about this specific software project only, its implementation and usage.
-
pinheadmz closed this on Mar 23, 2026
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-31 12:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-31 12:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me