wallet, refactor: rename file from migrate to legacybdb #34910

pull rkrux wants to merge 1 commits into bitcoin:master from rkrux:legacy-bdb changing 6 files +8 −8
  1. rkrux commented at 1:54 PM on March 24, 2026: contributor

    The wallet/migrate.h|cpp file contain all the code related to the Berkeley DB that was used in the legacy wallets. Although it's true that this code is used only within the context of wallet migration but the name of the file is not exact.

    This patch renames the file to legacybdb so that the intent is clearer in the call sites. I felt this rename might be necessary so that the name doesn't conflict with the upcoming wallet/migration.h|cpp files in #34909.

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. DrahtBot commented at 1:54 PM on March 24, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34910.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #34909 (wallet, refactor: modularise wallet by extracting out legacy wallet migration by rkrux)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. DrahtBot added the label Needs rebase on May 10, 2026
  4. wallet, refactor: rename file from migrate to legacybdb
    The wallet/migrate.h|cpp file contain all the code related to the
    Berkeley DB that was used in the legacy wallets. Although it's true
    that this code is used only within the context of wallet migration
    but the name of the file is not exact.
    
    This patch renames the file to legacybdb so that the intent is clearer in the
    call sites. I felt this rename might be necessary so that the name
    doesn't conflict with the upcoming wallet/migration.h|cpp files in PR 34909.
    362eb28b97
  5. rkrux force-pushed on May 11, 2026
  6. rkrux commented at 2:46 PM on May 11, 2026: contributor

    Rebased over master to incorporate changes from #35227.

  7. DrahtBot removed the label Needs rebase on May 11, 2026
  8. kevkevinpal commented at 4:47 PM on May 13, 2026: contributor

    Do you think it makes sense to rename it to migrate_legacybdb(.h|.cpp) instead, so we preserve the migrate wording?

  9. rkrux commented at 9:52 AM on May 14, 2026: contributor

    In #34909, migration.cpp|h files are added that covers all the migration workflow. I want to avoid having the migrate naming in these files because all the code here is within the context of legacy BDB, with the exception of couple comments that mention the migration workflow. We have sqlite.cpp|h files in the wallet directory, it seemed consistent to me to have corresponding entries for BDB but with the legacy prefix appended so that it's clear that all this code is not used now.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-15 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me