wallet: mark bip125-replaceable deprecated, remove walletrbf argument #34917

1. 
   rkrux commented at 9:53 am on March 25, 2026: contributor

   This patch set is in line with the deprecation & removal of outdated BIP 125 opt-in RBF signalling in wallet transactions.
2. wallet: mark `bip125-replaceable` key as deprecated in transaction RPCs

   Transactions are replaceable by default since v28 and the corresponding
   tweaking argument has been removed since v29. The related key from the
   mempool RPC has been marked deprecated as well since v29, this patch
   does the same for the wallet.

   849e13c8b0
3. wallet: remove `-walletrbf` argument

   All transactions are by default replaceable since v28, the wallet need not have
   a configuration option to opt into RBF signalling because it seems redundant
   now. The default behaviour of opting into RBF signalling is retained - for now.
   
   Users still have the option to opt out of RBF signalling via the individual
   transaction creation RPC request options.

   8c0a7d6f14
4. DrahtBot added the label Wallet on Mar 25, 2026
5. 
   DrahtBot commented at 9:53 am on March 25, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #bitcoin-core/gui/911 (Adds non-mempool wallet balance to overview by ajtowns)
   • #34897 (indexes: Don’t commit ahead of the flushed chainstate by mzumsande)
   • #33671 (wallet: Add separate balance info for non-mempool wallet txs by ajtowns)
   • #29278 (Wallet: Add maxfeerate wallet startup option by ismaelsadeeq)
   • #21283 (Implement BIP 370 PSBTv2 by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

   LLM Linter (✨ experimental)

   Possible typos and grammar issues:

   • explcitly -> explicitly [Typo in the added comment: # ...and check the result - it's not explcitly opt-in makes the text unclear.]

   2026-03-25 09:53:59

Contributors
rkrux DrahtBot w0xlt

Labels
Wallet