Test for mingw/wine issue #3494, where the upper word of time(NULL) return value gets clobbered.
Add test for GetTime() #3498
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_01_add_time_test changing 1 files +8 −0-
laanwj commented at 12:00 PM on January 9, 2014: member
-
eaafa23cbd
Add test for GetTime()
Test for mingw/wine issue #3494, where the upper word of time(NULL) return value gets clobbered.
-
Diapolo commented at 12:23 PM on January 9, 2014: none
IMHO a good addition, ACK.
-
BitcoinPullTester commented at 12:32 PM on January 9, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/eaafa23cbd83b7bda4b28779138c62446bbdea2a for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 1:02 PM on January 9, 2014: member
@diapolo can you test this test_bitcoin.exe on a real windows box:
https://download.visucore.com/bitcoin/test_bitcoin_eaafa23.zip
(this is the gitian-generated one, which will be different from the one from the pulltester or a locally-built one)
-
Diapolo commented at 3:12 PM on January 9, 2014: none
<pre> Running 109 test cases... *** No errors detected </pre>
-
laanwj commented at 3:14 PM on January 9, 2014: member
Eh, I ran the wrong test_bitcoin. I installed wine 1.7.1 from the winehq PPA on my Ubuntu 12.04 box and it still fails,
Running 109 test cases... util_tests.cpp(338): error in "gettime": check (GetTime() & ~0xFFFFFFFFLL) == 0 failed *** 1 failure detected in test suite "Bitcoin Test Suite"... I don't get it. @diapolo thanks for testing
- laanwj referenced this in commit 16ae1c0da1 on Jan 10, 2014
- laanwj merged this on Jan 10, 2014
- laanwj closed this on Jan 10, 2014
- laanwj deleted the branch on Apr 9, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors