CWallet: fix mapAddress book update #350

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:cwalletfix changing 2 files +63 −7

laanwj commented at 5:30 PM on June 26, 2011: member

Fix update of internal data structure (mapAddressBook) after changes to the address book, and add convenience methods EraseAddressBookName, GetDefaultAddress, SetDefaultAddress to be used from UI.

The problem was introduced in the new CWallet class; mapAddress book used to be updated in db.cpp. It now makes more sense to do the update directly in CWallet.
Fix update of internal data structure (mapAddressBook) and add methods EraseAddressBookName, GetDefaultAddress, SetDefaultAddress 4552bcb9eb
sgimenez commented at 8:08 PM on June 26, 2011: contributor

Hi, See also pull #335.
laanwj commented at 8:20 PM on June 26, 2011: member

hm right, seems that I did some duplicated effort :-)
sgimenez commented at 11:11 PM on June 26, 2011: contributor

Your Erase naming is more consistent with the name of other functions. SetDefaultAddress was missing. Also, I agree that code should be extracted from .h to .cpp files!

It's nice to see some activity, and thanks for the (indirect) feedback! :-)
sgimenez referenced this in commit e06e8122ae on Jun 27, 2011
sgimenez referenced this in commit 4d410cfce9 on Jun 27, 2011
sgimenez referenced this in commit d2b3d759bf on Jul 11, 2011
gavinandresen commented at 3:43 PM on October 5, 2011: contributor

If this is still relevant with the new QT GUI, please rebase and re-open.
gavinandresen closed this on Oct 5, 2011
luke-jr commented at 4:50 PM on December 5, 2011: member

For the record, this fix got merged for 0.3.24.
deadalnix referenced this in commit 14cb33f7c0 on Mar 9, 2017
classesjack referenced this in commit cb6179bb22 on Jan 2, 2018
lateminer referenced this in commit 94d72d64c4 on Oct 16, 2019
0xartem referenced this in commit 3230ab8ac4 on Feb 9, 2020
rajarshimaitra referenced this in commit ec706f2a06 on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#358 Address Book related Fixes #33647 [`v30.0`] `createNewBlock` never returns