mempool: remove all subsequent tx in pkg on failure #35017

1. 
   instagibbs commented at 8:52 pm on April 6, 2026: member

   This belt-and-suspenders check, if ever hit in production, could result in an inconsistent mempool if somehow the parent failed in the ConsensusScriptChecks but the child did not. Rather than allow the mempool to get in an inconsistent state, remove the following txs in the package.
2. DrahtBot added the label Mempool on Apr 6, 2026
3. 
   DrahtBot commented at 8:52 pm on April 6, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   LLM Linter (✨ experimental)

   Possible typos and grammar issues:

   • subsequent in package -> subsequent txs in the package [The phrase is missing the noun (“txs”/“transactions”), making the intended meaning unclear without guessing.]

   2026-04-08 18:21:31

4. in src/validation.cpp:1272 in 9a8cbc6356

   1265@@ -1266,6 +1266,10 @@ bool MemPoolAccept::SubmitPackage(const ATMPArgs& args, std::vector<Workspace>&
   1266                                             ws.m_ptx->GetHash().ToString()));
   1267             // Remove the transaction from the mempool.
   1268             if (!m_subpackage.m_changeset) m_subpackage.m_changeset = m_pool.GetChangeSet();
   1269+        }
   1270+        // Remove first failing tx and all subsequent in package
   1271+        if (!all_submitted) {
   1272+            Assume(m_subpackage.m_changeset);
   

   ---

   ---

   

   luke-jr commented at 6:16 pm on April 8, 2026:

   Should be Assert, since the next line will nullptr deref if the check fails

   ---

   

   instagibbs commented at 6:21 pm on April 8, 2026:

   changed
5. mempool: remove all subsequent tx in pkg on failure

   This belt-and-suspenders check, if ever hit in production,
   could result in an inconsistent mempool if somehow the
   parent failed in the ConsensusScriptChecks but the child did
   not. Rather than allow the mempool to get in an inconsistent
   state, remove the following txs in the package.

   623796abdf
6. instagibbs force-pushed on Apr 8, 2026

Contributors
instagibbs DrahtBot luke-jr

Labels
Mempool