gitian: Add -O2 for win32 build #3503

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_01_win32_gitian_optimize changing 1 files +3 −2
  1. laanwj commented at 8:41 AM on January 10, 2014: member

    In the win32 gitian descriptor the C*FLAGS are being overridden on configure, which causes the built-in optimization flags to be removed. Add -O2 manually (but not -g as we're doing nothing with the debug information).

    Improves performance of win32 gitian builds.

    As a bonus, fixes issue #3494 (see this comment: #3497 (comment) ).

  2. gitian: Add -O2 for win32 build
    In the win32 gitian descriptor the C*FLAGS are being overridden on
    `configure`, which causes the built-in optimization flags to be removed.
    Add `-O2` manually (but not `-g` as we're not doing anything with the
    debug information).
    
    Improves performance of win32 gitian builds.
    
    As a bonus, fixes issue #3497.
    0d512a9ee7
  3. BitcoinPullTester commented at 9:23 AM on January 10, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0d512a9ee7f01dbd6c06e83c2b3321d185790184 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. wtogami commented at 10:17 AM on January 10, 2014: contributor

    -O2 is really needed three times and with the link flags?

  5. laanwj commented at 10:34 AM on January 10, 2014: member

    Yes. It can't hurt anyway.

  6. laanwj referenced this in commit 6b06e4fd0d on Jan 10, 2014
  7. laanwj merged this on Jan 10, 2014
  8. laanwj closed this on Jan 10, 2014

  9. sipa commented at 6:47 PM on January 11, 2014: member

    What? We were building win32 binaries without any optimization?

  10. laanwj commented at 7:52 PM on January 11, 2014: member

    Yes. But only after the autotools switch. We never did an actual release that way.

  11. laanwj deleted the branch on Apr 9, 2014
  12. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me