contrib: Fix NameError in signet miner gbt() #35044

1. 
   torkelrogstad commented at 8:25 am on April 10, 2026: contributor

   The logging.warning call referenced bci["bestblockhash"], a variable from the calling scope do_generate() that is not available inside the Generate.gbt() method. This would crash with a NameError when getblocktemplate returned a template based on an unexpected previous block.

   Use the bestblockhash parameter that was already being passed in and used correctly in the comparison on the line above.

   The bug was introduced in 7b31332370 when the gbt logic was extracted into its own method — the if-condition was updated but the logging call was not.

2. contrib: Fix NameError in signet miner gbt()

   The logging.warning call referenced `bci["bestblockhash"]`, a variable
   from the calling scope `do_generate()` that is not available inside the
   `Generate.gbt()` method. This would crash with a NameError when
   getblocktemplate returned a template based on an unexpected previous
   block.
   
   Use the `bestblockhash` parameter that was already being passed in and
   used correctly in the comparison on the line above.
   
   The bug was introduced in 7b31332370 when the gbt logic was extracted
   into its own method — the if-condition was updated but the logging
   call was not.

   701bc2dc02
3. DrahtBot added the label Scripts and tools on Apr 10, 2026
4. 
   DrahtBot commented at 8:25 am on April 10, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

Contributors
torkelrogstad DrahtBot

Labels
Scripts and tools