The loop in FormatMoney accesses str[i-2] without first checking that i >= 2. If str.size() < 3, this could read out of bounds.
Fix by adding explicit bounds check i >= 2 to the loop condition.
util/moneystr: fix potential out-of-bounds access in FormatMoney #35057
pull flawlesscode254 wants to merge 1 commits into bitcoin:master from flawlesscode254:fix/out-of-bounds-moneystr changing 1 files +1 −1-
flawlesscode254 commented at 3:46 AM on April 12, 2026: none
-
30f6c59244
util/moneystr: fix potential out-of-bounds access in FormatMoney
The loop in FormatMoney accesses str[i-2] without first checking that i >= 2. If str.size() < 3, this could read out of bounds. Fix by adding explicit bounds check i >= 2 to the loop condition.
-
DrahtBot commented at 3:47 AM on April 12, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 6:25 AM on April 13, 2026: member
ai slop llm spam
- maflcko closed this on Apr 13, 2026
Contributors