When block.vtx is empty, block.vtx.size() - 1 causes integer underflow
since size() returns size_t (unsigned) and subtracting 1 wraps around
to a large number. This fix adds an explicit cast to int to prevent
the underflow.
Fixes a potential crash when processing blocks with zero transactions.
Fix/validation int underflow #35060
pull flawlesscode254 wants to merge 2 commits into bitcoin:master from flawlesscode254:fix/validation-int-underflow changing 2 files +2 −2-
flawlesscode254 commented at 4:09 AM on April 12, 2026: none
-
30f6c59244
util/moneystr: fix potential out-of-bounds access in FormatMoney
The loop in FormatMoney accesses str[i-2] without first checking that i >= 2. If str.size() < 3, this could read out of bounds. Fix by adding explicit bounds check i >= 2 to the loop condition.
-
b0ccce1126
validation: fix potential integer underflow in reverse loop
When block.vtx is empty, block.vtx.size() - 1 causes underflow since size() returns size_t (unsigned). Cast to int to prevent this.
-
DrahtBot commented at 4:09 AM on April 12, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 6:24 AM on April 13, 2026: member
ai slop llm spam
- maflcko closed this on Apr 13, 2026
Contributors