ci, iwyu: add compat to the list of FILES_WITH_ENFORCED_IWYU #35102

pull kevkevinpal wants to merge 1 commits into bitcoin:master from kevkevinpal:iwyu-compat changing 1 files +1 −1
  1. kevkevinpal commented at 2:39 AM on April 18, 2026: contributor

    Description

    Motivated by #33725 (comment) this continues the effort to enforce iwyu warnings.

    This is only adding the compat dir to the CI script since it seems to already pass the iwyu rules.

    Including compat into the CI will keep that part of the codebase hygienic


    I can close this if it isn't needed or necessary.

  2. iwyu: compat 649466a23e
  3. DrahtBot commented at 2:39 AM on April 18, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #35011 (ci, iwyu: Fix warnings in src/script and treat them as errors by BrandonOdiwuor)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. maflcko commented at 6:38 AM on April 18, 2026: member

    Thx, but I don't think it is useful to create conflicting pull requests with already open ones, when the diff is a single line change and that single line conflicts.

    It would be better to instead review the existing pull request.

    I am going to close this for now. You can pick this up again when the other one is closed or merged, and when this is still relevant after it is closed/merged.

  5. maflcko closed this on Apr 18, 2026

  6. kevkevinpal commented at 11:25 AM on April 18, 2026: contributor

    Thx, but I don't think it is useful to create conflicting pull requests with already open ones, when the diff is a single line change and that single line conflicts.

    It would be better to instead review the existing pull request.

    I am going to close this for now. You can pick this up again when the other one is closed or merged, and when this is still relevant after it is closed/merged.

    Gotcha, no problem


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me