wallet: Report importdescriptors timestamp errors per item #35253

pull carlosdouradodev wants to merge 1 commits into bitcoin:master from carlosdouradodev:fix-importdescriptors-timestamp-errors changing 2 files +39 −8
  1. carlosdouradodev commented at 9:13 AM on May 10, 2026: none

    Fixes #35181

    This updates importdescriptors to return per-request errors for missing or invalid timestamp fields instead of aborting the whole batch. Requests that fail timestamp validation are skipped, while later valid requests can still be processed.

    The rescan result handling now preserves existing per-item errors before checking request timestamps.

    Testing:

    • cmake --build build --target bitcoind bitcoin-cli -j 8
    • test/functional/wallet_importdescriptors.py --configfile=/home/carl/bitcoin/build/test/config.ini --portseed=35181
    • git diff --check
  2. wallet: Report importdescriptors timestamp errors per item
    Missing or invalid timestamp values previously aborted the whole batch before importdescriptors could return per-request results. Catch those errors in the batch loop so later requests can still be processed.
    979703aa5f
  3. DrahtBot added the label Wallet on May 10, 2026
  4. DrahtBot commented at 9:14 AM on May 10, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35253.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. sedited commented at 9:36 AM on May 10, 2026: contributor

    The testing instructions are wrong in a flavor that is typical for LLM PR submissions, which makes me think this PR and its description were not understood by the developer writing it. We require developers to understand the changes they are submitting, since review otherwise turns into reviewers prompting the developers LLM. Closing.

  6. sedited closed this on May 10, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-11 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me