update copyright year to 2014 #3537

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:hello_2014 changing 1 files +1 −1

Diapolo commented at 4:12 PM on January 14, 2014: none

No description provided.
update copyright year to 2014 8c20bbbed9
in src/clientversion.h:None in 8c20bbbed9
```
  18 | @@ -19,7 +19,7 @@
  19 |  
  20 |  // Copyright year (2009-this)
  21 |  // Todo: update this when changing our copyright comments in the source
  22 | -#define COPYRIGHT_YEAR 2013
  23 | +#define COPYRIGHT_YEAR 2014
```
laanwj commented at 4:15 PM on January 14, 2014:

This is not needed anymore, we define all of these in bitcoin-config.h. It's just a dummy value in case HAVE_CONFIG_H is not defined. (maybe we should update the comment tho...)

Diapolo commented at 4:34 PM on January 14, 2014:

It doesn't hurt anyway?

richardzhyang commented at 4:39 PM on January 14, 2014:

ok

laanwj commented at 4:41 PM on January 14, 2014:

It doesn't hurt, but I think the point of adding the year to configure.ac was that we can update it in one place. If we keep updating it here we can just as well remove it from the .ac again.

We want to reduce the number of places where it needs to be updated, not increase it.

Diapolo commented at 4:45 PM on January 14, 2014:

IMHO it's more obvious to update it in a header...
BitcoinPullTester commented at 4:38 PM on January 14, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8c20bbbed934891fb9e9b5ea90eea610034ad11c for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 4:43 PM on January 14, 2014: member

Anyway, ACK
laanwj referenced this in commit 7fb5894b4c on Jan 14, 2014
laanwj merged this on Jan 14, 2014
laanwj closed this on Jan 14, 2014
Diapolo deleted the branch on Jan 14, 2014
laanwj commented at 4:52 PM on January 14, 2014: member

Created an issue for this, #3539
DrahtBot locked this on Sep 8, 2021

Contributors