rest: use empty() instead of size()/length() comparisons #35423

pull gabrysh wants to merge 1 commits into bitcoin:master from gabrysh:rest-use-empty changing 1 files +5 −5
  1. gabrysh commented at 10:57 PM on May 30, 2026: none

    Replace several .size() == 0, .size() > 0, .length() == 0 and .length() > 0 emptiness checks in src/rest.cpp with the more idiomatic and self-documenting empty() / !empty().

    This is a behaviour-preserving cleanup.

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. rest: use empty() instead of size()/length() comparisons
    Replace several `.size() == 0`, `.size() > 0`, `.length() == 0` and `.length() > 0` emptiness checks in src/rest.cpp with the more idiomatic and self-documenting `empty()` / `!empty()`.
    
    This is a behaviour-preserving cleanup.
    f7afba9b63
  3. DrahtBot added the label RPC/REST/ZMQ on May 30, 2026
  4. DrahtBot commented at 10:57 PM on May 30, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35423.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. pinheadmz commented at 11:07 PM on May 30, 2026: member

    Please don't open new pull requests just for tiny refactors, they are a drag on our integration testing infrastructure, maintainer time and reviewer time. See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring:

    Trivial pull requests or pull requests that refactor the code with no clear benefits may be immediately closed by the maintainers to reduce unnecessary workload on reviewing.

    There are many more significant ways to contribute to Bitcoin -- for example, look for good first issues.

  6. pinheadmz closed this on May 30, 2026

  7. gabrysh deleted the branch on May 30, 2026
  8. jonatack commented at 1:07 AM on May 31, 2026: member

    There are many more significant ways to contribute to Bitcoin -- for example, look for good first issues.

    (The "good first issues" label and template have been removed going forward: #35399 and #35400 -- here is an alternative suggestion: #35399 (comment).)


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-31 17:50 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me