This PR removes direct access to process-wide state from ExternalSignerScriptPubKeyMan.
Instead of reading gArgs/Params() from the SPKM, the wallet load/setup path now reads the external signer command and chain once, stores them on CWallet, and passes the narrow values into the external signer SPKM.
This keeps argument and chain selection at the wallet boundary and makes the SPKM less coupled to global state.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Are you still working on this?
ExternalSignerScriptPubKeyMan::GetExternalSigner() reached into global state
(gArgs for -signer, Params() for the chain type) from deep inside the signing
and descriptor-setup paths.
Capture both in LoadWalletArgs -- where the wallet already reads its other
settings from the injected WalletContext -- store them on CWallet, and pass
them to ExternalSignerScriptPubKeyMan through its LoadFromStorage() and
CreateNew() factories. GetExternalSigner() now takes the command and chain as
parameters.
When -signer is unset the command is empty and the same "restart bitcoind
with -signer" error is returned. The chain string comes from the same
ArgsManager that Params() is selected from at startup.
-signer is now read when the wallet is loaded rather than each time a signer
is used, so a value changed at runtime (e.g. via the GUI options dialog,
which already requires a restart) only applies to wallets loaded afterwards.
This matches the other wallet options read in LoadWalletArgs.
Add unit tests asserting that:
- GetExternalSigner() with an empty command returns the "needs -signer"
error before any external process is launched.
- LoadWalletArgs captures -signer and the chain from the wallet's
injected ArgsManager. The chain is set to differ from the global
Params(), so reading it from globals would fail the test.
In wallet_signer.py, check the debug log when spending from a wallet
loaded with a disconnected signer. A missing signer and an empty -signer
command both surface as the same "External signer not found" RPC error,
so the log message is what shows that the configured command reached
the loaded wallet's ScriptPubKeyMan.