[Qt] add utilitydialog.cpp/h and helpmessage class #3548

Diapolo commented at 3:11 PM on January 16, 2014: none

adds a nice and well formated dialog, which displays our -? help message (all options/paramaters)
moves aboutdialog.cpp/h to the new utilitydialog
move GUI shutdown window to utilitydialog

helpmessagedialog

laanwj commented at 8:31 AM on January 17, 2014: member

Dialog looks good.

I'm thinking that we should maybe have a implementation/header file dedicated to 'utility dialogs' such as this one and the about box. I don't really like how this one is almost empty, for example:

https://github.com/bitcoin/bitcoin/blob/master/src/qt/aboutdialog.cpp

Edit: Another one we could throw in that bag would be the "Shutting down dialog". It's currently declared on-the-fly in bitcoin.cpp.

Diapolo commented at 3:05 PM on January 17, 2014: none

I agree, we should perhaps implement a utildialog.cpp/.h and try to reuse it for different dialogs. Anyway I consider this out of the scope of this pull...

I opened an issue for your suggestion: #3552.

laanwj commented at 3:12 PM on January 17, 2014: member

I just mean 'move them to one implementation file'. It doesn't have to be one class. You can easily do that in this pull.

Diapolo commented at 3:19 PM on January 17, 2014: none

Oh I missunderstood that, sure that can be easily done ^^.

Diapolo commented at 1:36 PM on January 18, 2014: none

@laanwj Let's see what you and @BitcoinPullTester says.

Diapolo commented at 1:44 PM on January 18, 2014: none

One thing I observed, when shutdown is taking longer and you see the Shutdown window. I was able to double-click on the tray icon and saw the no-wallet UI (perhaps the wallet was unloaded already). Is this intended @laanwj? I'm also not sure this has to do with this pull, just mentioning.

laanwj commented at 1:49 PM on January 18, 2014: member

@Diapolo that's indeed strange, but has nothing to do with this pull, it's now possible to trigger this because the event loop is functional during shutdown.

Edit: a way to prevent this would be to delete the main window in initiateShutdown. This removes the tray icon during shutdown. Edit.2: or another way to disable all the tray menu actions in setClientModel(0), maybe this is better, as the tray icon can stay visible until the program has really quit.

Diapolo commented at 3:55 PM on January 18, 2014: none

@laanwj Can you help out?

Edit: Seems I forgot the utilitydialog moc in the makefile...

[Qt] add utilitydialog.cpp/h and helpmessage class

- adds a nice and well formated dialog, which displays our -? help message
  (all options/paramaters)
- moves aboutdialog.cpp/h to the new utilitydialog
- move GUI shutdown window to utilitydialog

7b50bb2f1b

BitcoinPullTester commented at 4:50 PM on January 18, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7b50bb2f1b96cb8964819e03eb044c3b88746946 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

laanwj commented at 11:50 AM on January 20, 2014: member

If you forget files in the makefile.am they will not make it into 'make dist' and the pull tester will fail (good test!), that also tripped me up once.

ACK

laanwj referenced this in commit 77a1607ce8 on Jan 21, 2014

laanwj merged this on Jan 21, 2014

laanwj closed this on Jan 21, 2014

laanwj commented at 8:03 AM on January 21, 2014: member

Now that you created a nice window for this, what about moving it to "Help"->"Command-line options" instead of the debug window?

Diapolo deleted the branch on Jan 22, 2014

Diapolo commented at 8:49 AM on January 22, 2014: none

Good idea, will create a pull...

sidhujag referenced this in commit f410e08a90 on Jul 7, 2020

DrahtBot locked this on Sep 8, 2021