qt: allow `walletpassphrase` in debug console without -server #3553

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_01_walletpassphrase_qt changing 5 files +30 −3
  1. laanwj commented at 3:36 PM on January 17, 2014: member

    Currently it is only possible to use walletpassphrase to unlock the wallet when bitcoin is started in server mode.

    Almost everything that manipulates the wallet in the RPC console (for example, importprivkey) needs the wallet to be unlocked and is thus unusable without -server.

    This is pretty unintuitive to me, and I'm sure it's even more confusing to users.

    Solve this with a very minimal change: by making the GUI start a dummy RPC thread just to handle deadline timers.

  2. qt: allow `walletpassphrase` in debug console without -server
    Currently it is only possible to use `walletpassphrase` to unlock the
    wallet when bitcoin is started in server mode.
    
    Almost everything that manipulates the wallet in the RPC console
    needs the wallet to be unlocked and is thus unusable without -server.
    
    This is pretty unintuitive to me, and I'm sure it's even more confusing
    to users.
    
    Solve this with a very minimal change: by making the GUI start a
    dummy RPC thread just to handle timeouts.
    a8db31c83d
  3. BitcoinPullTester commented at 4:18 PM on January 17, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a8db31c83d6a43e07f741f7f61b1bf0df87621c7 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. sipa commented at 5:12 PM on January 18, 2014: member

    ACK

  5. laanwj referenced this in commit 8b2cf12b53 on Jan 23, 2014
  6. laanwj merged this on Jan 23, 2014
  7. laanwj closed this on Jan 23, 2014

  8. laanwj deleted the branch on Apr 9, 2014
  9. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me