No description provided.
Merge src/leveldb change: temporarily revert to writing .sst files. #3555
pull sipa wants to merge 5109 commits into bitcoin:master from sipa:leveldbsst changing 728 files +307400 −12-
sipa commented at 1:32 PM on January 18, 2014: member
-
cf74e8cb5e
Merge pull request #3320 from laanwj/2013_11_cli_split
bitcoin-cli: remove unneeded dependencies (only minor code movement)
-
ccd1372dd0
[Qt] small notificator and style changes
- remove default arguments for notificator - re-order some calls to use same ordering in Qt files - style police changes (spaces, comments and such)
-
f15bd3c96f
Merge pull request #3285
d3207b6 [Qt] coin-control features GUI cleanup 3 (Philip Kaufmann) 834e14e [Qt] coin-control features GUI cleanup 2 (Philip Kaufmann)
-
1e01f7c506
Payment request URI syntax changed, from request=... to r=...
BIP 72 was changed to save six bytes in bitcoin: URIs.
-
6c98cca9e4
qt: use deleteLater to remove send entries
Use deleteLater() instead of delete, as it is not allowed to delete widgets directly in an event handler. Should solve the MacOSX random crashes on send with coincontrol.
-
00cfc9f074
Merge pull request #3355
6c98cca qt: use deleteLater to remove send entries (Wladimir J. van der Laan)
-
bbb093652e
Move HelpExample* from rpcwallet to rpcserver
General functions used throughout the RPC framework don't belong in rpcwallet.
-
991685d3dc
Move getinfo to rpcnet.cpp
Where to place `getinfo` is a difficult issue as it shows information from the wallet, net and block chain. However, I moved it out of rpcwallet as the command needs also to be available without wallet.
-
48ba56cdfd
Delimit code with #ifdef ENABLE_WALLET
Delimit all code that uses the wallet functions in implementation files that conditionally use the wallet.
-
d004d7279f
Move CAddrDB frrom db to net
This was a leftover from the times in which peers.dat depended in BDB. Other functions in db.cpp still depend on BerkelyDB, to be able to compile without BDB this (small) functionality needs to be moved to another file.
-
4f9e993bc9
Add --disable-wallet option to build system
Make it possible to build Bitcoin without wallet (and thus without BDB) so that it only functions as node.
-
ae6ea5a6fa
Update build-unix.md to mention --disable-wallet
Mention the new --disable-wallet mode. Also, correct the BDB entry in the dependencies table.
-
829c920387
Move CCryptoKeyStore to crypter.cpp
This breaks the dependency on crypter for disable-wallet builds.
-
5094f8d46f
Split off rpc_wallet_tests
Split wallet tests from other RPC tests. Now no #ifdef ENABLE_WALLET are needed anymore in either file.
-
d3ef9b00ec
Prevent empty transactions from being added to vtxPrev
CWalletTx::AddSupportingTransactions() was adding empty transaction to vtxPrev in some cases. Skip over these. Part one of the solution to #3190. This prevents invalid vtxPrev from entering the wallet, but not current ones being transmitted.
-
4ef92a9067
Refuse to retransmit transactions without vins
Versions of bitcoin before 0.8.6 have a bug that inserted empty transactions into the vtxPrev in the wallet, which will cause the node to be banned when retransmitted, hence add a check for !tx.vin.empty() before RelayTransaction.
-
80ca273b7f
Merge pull request #3357
4ef92a9 Refuse to retransmit transactions without vins (Wladimir J. van der Laan)
-
b1961523f1
Merge pull request #3356
d3ef9b0 Prevent empty transactions from being added to vtxPrev (Wladimir J. van der Laan)
-
fix typo in rpcnet.cpp 38cbeab1ff
-
ac57a2320f
Merge pull request #3359
38cbeab fix typo in rpcnet.cpp (Philip Kaufmann)
-
Change release-process.md to sign release tags cc75306ceb
-
d6d12f932d
Merge pull request #3362 from Michagogo/signed-tags
Change release-process.md to sign release tags
-
b4297c8fff
Merge pull request #3353
1e01f7c Payment request URI syntax changed, from request=... to r=... (Gavin Andresen)
-
4cf3411056
[Qt] misc PaymentServer changes (e.g. changes to eventFilter())
- make eventFilter() private and pass events on to QObject::eventFilter() instead of just returning false - re-work paymentservertest.cpp to correctly handle the event test after the above change (rewrite test_main to allow usage of QCoreApplication:: in the tests) - delete socket when we were unable to connect in ipcSendCommandLine() - show a message to the user if we fail to start-up (instead of just a debug.log entry) - misc small comment changes
-
9ac11a4e1e
Merge pull request #3254
4cf3411 [Qt] misc PaymentServer changes (e.g. changes to eventFilter()) (Philip Kaufmann)
-
a702a0b61d
Restore hex to getrawtransaction vout scriptPubkey.
Commit be066fad accidentally removed the hex field. This gets in the way of doing offline signing. (credit belongs to sipa for actually looking for the cause instead of being lazy like me and just shrugging and writing the scriptpubkey from the asm.)
-
fbbed19b78
Merge pull request #3365 from gmaxwell/hexify
Restore hex to getrawtransaction vout scriptPubkey.
-
05e27c6641
Merge pull request #3332
5094f8d Split off rpc_wallet_tests (Wladimir J. van der Laan) 829c920 Move CCryptoKeyStore to crypter.cpp (Wladimir J. van der Laan) ae6ea5a Update build-unix.md to mention --disable-wallet (Wladimir J. van der Laan) 4f9e993 Add --disable-wallet option to build system (Wladimir J. van der Laan) d004d72 Move CAddrDB frrom db to net (Wladimir J. van der Laan) 48ba56c Delimit code with #ifdef ENABLE_WALLET (Wladimir J. van der Laan) 991685d Move getinfo to rpcnet.cpp (Wladimir J. van der Laan) bbb0936 Move HelpExample* from rpcwallet to rpcserver (Wladimir J. van der Laan)
-
6893d74e15
Merge pull request #3322
26d1b65 src/Makefile.am: Simplify clean of leveldb (Josh Triplett) a26a367 configure.ac: Check for miniupnpc headers, not just -lminiupnpc (Josh Triplett) 82ccb05 autogen.sh: Stop passing --verbose to autoreconf (Josh Triplett) e12dafd autogen.sh: Use long options to autoreconf, for self-documentation (Josh Triplett) 19b9add autogen.sh: Support running from outside the source directory (Josh Triplett) 97d285a autogen.sh: Use set -e to fail if any command fails (Josh Triplett) f80b723 autogen.sh: Add a /bin/sh shebang. (Josh Triplett)
-
70370ae502
Merge pull request #3348
ccd1372 [Qt] small notificator and style changes (Philip Kaufmann)
-
Add main-specific node state b2864d2fb3
-
6027b460e4
Add rpc command 'getunconfirmedbalance' to obtain total unconfirmed balance
Conflicts: src/rpcserver.cpp
-
80ecf6702a
Add ThreadGetMyExternalIP to net thread group
Fixes #3372 -- crash at shutdown.
-
7202d9d9bf
Merge pull request #3276 from sipa/nodestate
Add main-specific node state & move ban score
-
4a85e06750
Allow mining RPCs with --disable-wallet
The following mining-related RPC calls don't use the wallet: - getnetworkhashps - getmininginfo - getblocktemplate - submitblock Enable them when compiling with --disable-wallet.
-
Move internal miner functionality together acfa03337e
-
fbc7a96d03
Re-enable miner tests in --disable-wallet mode
Use a fixed script instead of a CReserveKey from the wallet. This does not affect the functionality or result of the tests as they never check the state of the wallet in the first place.
-
some string and indentation updates in init/rpcclient b6aafca03d
-
7266bb1bdc
Merge pull request #3373
80ecf67 Add ThreadGetMyExternalIP to net thread group (Gavin Andresen)
-
cleanup includes in rpcnet.cpp fdbdb7f345
-
84f8551f3a
[Qt] misc small Mac related changes/cleanups
- cleanup Info.plist.in and specify high DPI mode enable command as per http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-ios-and-x11/ - move setting of QApplication::setAttribute() to bitcoin.cpp and add attribute for enabling use of high DPI pixmaps for Qt >= 5.1 - add missing setWindowTitle() on Mac - cleanup Mac / non-Mac setup in bitcoingui.cpp
-
6694f4a7a2
Merge pull request #3297
84f8551 [Qt] misc small Mac related changes/cleanups (Philip Kaufmann)
-
f914c7a1a4
rpcwallet: use EnsureWalletIsUnlocked() where possible
- replaces a pwalletMain->IsLocked() check - in keypoolrefill init kpSize to 0 as we have the logic to determine max kpSize in pwalletMain->TopUpKeyPool() anyway
-
20a3c80790
Merge pull request #3178
f914c7a rpcwallet: use EnsureWalletIsUnlocked() where possible (Philip Kaufmann)
-
955787f83f
Merge pull request #3207
666893b qt: keep a list of requested payments (Wladimir J. van der Laan)
-
962b1cf441
Fix infinite loop with LogPrint on Windows
Running -printtodebugger -debug (or -debug=lock), compiled with -DDEBUG_LOCKORDER would infinite loop on Windows because every critical section lock/unlock triggers a LogPrint. Solution is to use the raw boost mutex instead of a CCriticalSection.
-
0b238b2786
Use thread-local storage for LogPrint(category...)
This prevents crashes at shutdown where a global destructor calls LogPrint(category...) after mapMultiArgs has been deleted.
-
d47bbbd261
Merge pull request #3368 from laanwj/2013_11_disable_wallet_mining
Allow mining RPCs with --disable-wallet
-
b9c3416723
Add protobuf-compiler dependency package for debian
Fixes #3361
-
fb96e28b29
Merge pull request #3378
b9c3416 Add protobuf-compiler dependency package for debian (Wladimir J. van der Laan)
-
Release process: add section about announcing new release 4f99b1601b
-
bd70562f66
[Qt] add messages when handling local payment request files
- important for the open URI dialog to give users feedback when a file is invalid etc.
-
6939a0d50e
Merge pull request #3350
fdbdb7f cleanup includes in rpcnet.cpp (Philip Kaufmann) b6aafca some string and indentation updates in init/rpcclient (Philip Kaufmann)
-
3e01c00f42
Add tests for correct and incorrect order of signatures for a multisig
(P2SH)
-
Update build-osx.md 9392924d0d
-
ef20293c51
Merge pull request #3389 from regergregregerrge/patch-1
Update build-osx.md
-
69127034c3
Merge pull request #3379
4f99b16 Release process: add section about announcing new release (Wladimir J. van der Laan)
-
24646ee76f
[Qt] fix possibilty to delete last sendcoins entry
- hide the entry about to be deleted, and if it is the last entry add a new one, so that we always have one entry in our list
-
7df07b3f45
[Qt] fix RecentRequestsTableModel function ambiuguity
- fixes a compiler ambiguity error with ::createIndex() called in RecentRequestsTableModel::index() - also add some Q_UNUSED() macros
-
5e47c2b70a
Merge pull request #3382
24646ee [Qt] fix possibilty to delete last sendcoins entry (Philip Kaufmann)
-
b878b763cb
build: fix syntax error on older m4/autoconf.
Fixes #3358. This affects preinstalled autotools on osx 10.6.
-
Use 'make check' instead of 'make test' 3f2c6f8654
-
c4880e0172
Merge pull request #3395 from ldenman/patch-2
Use 'make check' instead of 'make test'
-
fb34be6d59
Merge pull request #3393 from theuni/build-10.6
build: fix syntax error on older m4/autoconf.
-
Merge src/leveldb changes for LevelDB 1.15 ed873a301e
-
efdfee423f
build: fix detection of boost libs on multi-arch distros
Fixes #3219.
-
docs: remove workaround instructions now that the problem is fixed 952fe2ef32
-
d670cdd698
Merge pull request #3407
952fe2e docs: remove workaround instructions now that the problem is fixed (Cory Fields) efdfee4 build: fix detection of boost libs on multi-arch distros (Cory Fields)
-
150771c4f3
Merge pull request #3326
ad898b4 Increase default -blockmaxsize/prioritysize to 750K/50K (Gavin Andresen)
-
666225f687
Merge pull request #3387
3e01c00 Add tests for correct and incorrect order of signatures for a multisig (P2SH) (Tamas Blummer)
-
22f0135df0
Rebrand to `Bitcoin Core`
Only messages for now, executable names and other file names can be changed later if necessary and safe. Do not do an all-sweeping change. Some occurences of Bitcoin-Qt need to be kept: - Applicationname: this is used to determine the registry entry names, we don't want to lose settings over a silly name change. - Where it refers to the executable name instead of the product name.
-
a9a37c8bb5
update help for -blockmaxsize and blockprioritysize
- was left out in #3326
-
5e2fb330fd
Merge pull request #3409
a9a37c8 update help for -blockmaxsize and blockprioritysize (Philip Kaufmann)
-
fixed documetation on hardening flags 08b93f9a65
-
6bfaf2ac37
Merge pull request #3411
08b93f9 fixed documetation on hardening flags (HaltingState)
-
add new RPC implementation file `rpcmisc.cpp` 652e156951
-
16bc9aaf8a
Move `getinfo` from rpcnet to rpcmisc
`getinfo` is a general info method which shows information from multiple sources, it doesn't belong in rpcnet.cpp or any of the other current RPC implementation files.
-
a943bde6f0
Move `settxfee` from rpcblockchain to rpcwallet
`settxfee` only affects the wallet, not the block chain.
-
cd7fa8bb43
Move `nTransactionFee` from main.cpp to wallet.cpp
Transaction fee is only used by the wallet. No need for it to be in main.cpp.
-
452955f5be
Move `validateaddress` from rpcwallet to rpcmisc
Enables it in --disable-wallet compiles. Delimit wallet-using part using #ifdef ENABLE_WALLET.
-
723a03d2de
Move `createmultisig` from rpcwallet to rpcmisc
Enables it in --disable-wallet compiles.
-
c3a7f516e7
Move `verifymessage` from rpcwallet to rpcmisc
Enables it in --disable-wallet compiles.
-
Remove unused ThreadSafeHandleURI from ui_interface 37e67d37c1
-
ca2c83da50
Remove unused ThreadSafeAskFee from ui_interface
ThreadSafeAskFee is effectively unused. It is only called when the fAskFee parameter on SendMoney or SendMoneyToDestination is true, which never happens. Remove it.
-
8a7606f35b
Merge pull request #3377
0b238b2 Use thread-local storage for LogPrint(category...) (Gavin Andresen) 962b1cf Fix infinite loop with LogPrint on Windows (Gavin Andresen)
-
9e9056cd1a
Remove -logtodebugger
`-logtodebugger` is a strange, obscure, WIN32-only (mostly MSVC) thing. Let's clean up the options a bit get rid of it. test_bitcoin was using fLogToDebugger as a way to prevent logging to debug.log. For this, add a boolean (not exposed as option) fLogToDebugLog that defaults to true and is disabled in the tests.
-
bccd5324ab
Fix unit test error on OSX 10.9 using Apple LLVM v5.0.
Before the fix, there were 6 errors such as : serialize_tests.cpp:77: error in "noncanonical": incorrect exception std::ios_base::failure is caught It turns out that ex.what() returns following string instead of "non-canonical ReadCompactSize()" "non-canonical ReadCompactSize(): unspecified iostream_category error" After the fix, unit test passed. The test ran using Apple LLVM v5.0 on OSX 10.9 and the unit test error happened because of different error messages by different compilers. g++ --version on my development environment. ``` Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1 Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn) Target: x86_64-apple-darwin13.0.0 Thread model: posix ```
-
qt: use GUIUtil::dateTimeStr in coincontrol 93a5d0bb98
-
d05ce63c98
Merge pull request #3421
93a5d0b qt: use GUIUtil::dateTimeStr in coincontrol (Wladimir J. van der Laan)
-
a5a65bbc90
Merge pull request #3420
bccd532 Fix unit test error on OSX 10.9 using Apple LLVM v5.0. (Kangmo)
-
0205abd83d
Improve unit test code not to compare with explanatory messages for each platform.
Instead, use have an exception object to check if the string returned by what() on the raised exception matches the string returned by what() on the expected exception instance. This way, we do not need to list all different possible explanatory strings for different platforms in the test code, and make it simple. (The idea is by Cory Fields.)
-
3d7c66d75d
Merge pull request #3423
0205abd Improve unit test code not to compare with explanatory messages for each platform. Instead, use have an exception object to check if the string returned by what() on the raised exception matches the string returned by what() on the expected exception instance. This way, we do not need to list all different possible explanatory strings for different platforms in the test code, and make it simple. (The idea is by Cory Fields.) (Kangmo)
-
4a61c39456
qt: status WalletModel::Aborted is no longer used
Aborting transactions happens in the GUI now as it should, not the backend.
-
06eb2f215b
Seperate out wallet options in help message
Seperate out the wallet options in HelpMessage, and don't show them if compiled with --disable-wallet. Also add documentation for `-disablewallet` option.
-
2ed38d11a8
Merge pull request #3408
22f0135 Rebrand to `Bitcoin Core` (Wladimir J. van der Laan)
-
qt: Update English language file for translators 88ba2643f0
-
93a7861d71
Merge pull request #3425
88ba264 qt: Update English language file for translators (Wladimir J. van der Laan)
-
16ec9044d1
Don't create empty transactions when reading corrupted wallet
The current transaction loading code is not exception safe. An exception during deserialization causes an empty transaction to be left behind in the wallet. Fix this by building the transaction separately and adding it only to the wallet at the end. Fixes #3333.
-
1ad26362c9
qt: Prevent non-functional GUI from popping up during Init
When a InitError or InitWarning happens, the GUI pops up but is unusable (until Init finishes). This is caused by showNormalIfMinimized. Add a message flag to skip this call for Init errors or warnings.
-
Fix typo in unit-tests.md ba4ceb15d6
-
3743b80528
Merge pull request #3430 from ldenman/patch-1
Fix typo in unit-tests.md
-
Fix typos in spendfrom README 131c3db8fb
-
some more small re-branding changes (Bitcoin Core) 46469d0f86
-
8f5fd94497
Merge pull request #3434
46469d0 some more small re-branding changes (Bitcoin Core) (Philip Kaufmann)
-
a549842499
Merge pull request #3431
131c3db Fix typos in spendfrom README (Lake Denman)
-
6c1bf199ca
[Qt] style-police, add missing license headers
- add missing license headers in Mac files - small code formating cleanups
-
9c6546c90e
Rebrand README.md
How could I forgot this file...
-
cf920b657d
Merge pull request #3405
55c6890 Squashed 'src/leveldb/' changes from 936b461..e991315 (Pieter Wuille)
-
5ac8b6eeaa
Merge pull request #3435
9c6546c Rebrand README.md (Wladimir J. van der Laan)
-
Fix heading in README.md c8af33aa75
-
97203994a4
Merge pull request #3381
7df07b3 [Qt] fix RecentRequestsTableModel function ambiuguity (Philip Kaufmann)
-
03d9dd47f6
Merge pull request #3424
06eb2f2 Seperate out wallet options in help message (Wladimir J. van der Laan)
-
57fdd68aac
Merge pull request #3415
4a61c39 qt: status WalletModel::Aborted is no longer used (Wladimir J. van der Laan) ca2c83d Remove unused ThreadSafeAskFee from ui_interface (Wladimir J. van der Laan) 37e67d3 Remove unused ThreadSafeHandleURI from ui_interface (Wladimir J. van der Laan)
-
a5824bb3c6
Merge pull request #3433
6c1bf19 [Qt] style-police, add missing license headers (Philip Kaufmann)
-
636a42bd0e
Remove ui_interface ThreadSafeAskFee residue
Missed these in ca2c83d (#3415).
-
19a5676280
Use mutex pointer instead of name for AssertLockHeld
This makes it useable for non-global locks such as the wallet and keystore locks.
-
956916806a
Document cs_wallet lock and add AssertLockHeld
Add locking assertions to wallet to all methods that access internal fields and do not aquire the cs_wallet mutex.
-
012ca1c9e4
LoadWallet: acquire cs_wallet mutex before clearing setKeyPool
Make the function mutex-aware, to prevent having to lock cs_wallet at the call site in Init.
-
285cf7a1a6
Merge pull request #3412
c3a7f51 Move `verifymessage` from rpcwallet to rpcmisc (Wladimir J. van der Laan) 723a03d Move `createmultisig` from rpcwallet to rpcmisc (Wladimir J. van der Laan) 452955f Move `validateaddress` from rpcwallet to rpcmisc (Wladimir J. van der Laan) cd7fa8b Move `nTransactionFee` from main.cpp to wallet.cpp (Wladimir J. van der Laan) a943bde Move `settxfee` from rpcblockchain to rpcwallet (Wladimir J. van der Laan) 16bc9aa Move `getinfo` from rpcnet to rpcmisc (Wladimir J. van der Laan) 652e156 add new RPC implementation file `rpcmisc.cpp` (Wladimir J. van der Laan)
-
df840de5da
Make bitcoin compile without wallet if "db_cxx.h" is not present
Moved includes of "db.h" into #ifdef ENABLE_WALLET blocks or remove them.
-
d2b6de031f
qt: Make sure overviewpage button is pressed at startup
Due to walletframe changes, the overview page button is no longer automatically selected at startup even though the overview page is shown.
-
cc661b4d7f
Merge pull request #3438
d2b6de0 qt: Make sure overviewpage button is pressed at startup (Wladimir J. van der Laan)
-
2ea980a77c
qt: Treat regtest as testnet
No need to do anything special in the GUI for regtest mode, but do treat it at testnet not mainnet to prevent confusion.
-
326b5bb9d0
Merge pull request #3437
2ea980a qt: Treat regtest as testnet (Wladimir J. van der Laan)
-
23981b1f47
Merge pull request #3369
6027b46 Add rpc command 'getunconfirmedbalance' to obtain total unconfirmed balance (Michael Bauer)
-
f498d43ee2
Merge pull request #3416
9e9056c Remove -logtodebugger (Wladimir J. van der Laan)
-
init: add better formating for some command-line options 3c955993a4
-
3380713af5
[Qt] coin control change address handling update
- re-work change address handling so that default is CNoDestination(), until a verified and known change address was entered (easier code flow) - add a missing NULL pointer check for adresstablemodel - add a missing text when opening coin control address selection for priority and ensure the label is black - add a missing . at the end of a sentence
-
9e508b5588
Merge pull request #3439
3c95599 init: add better formating for some command-line options (Philip Kaufmann)
-
8b9adca446
Allow `-noserver` with bitcoind
Allow running bitcoind without server. - Default to -server mode (of course) for bitcoind with SoftSetBoolArg - Remove fForceServer argument from AppInit2 - Move fDaemon to a static variable in bitcoind
-
365350140a
Merge pull request #3391
3380713 [Qt] coin control change address handling update (Philip Kaufmann)
-
5fe19d640e
qt: make wallet test consistent
Add a function `WaitBlocks` to wait for blocks to propagate to all three nodes, and use this instead of waiting a fixed time of one second. Fixes #3445.
-
extend std::exception logging in txdb.cpp 96e5f61d6c
-
f46babc8c8
Merge pull request #3451
5fe19d6 qt: make wallet test consistent (Wladimir J. van der Laan)
-
d78f35a909
Explicitly ensure that wallet is unlocked in `importprivkey`
This makes for a more useful error reply (fixes #957).
-
362755d018
Merge pull request #3427
1ad2636 qt: Prevent non-functional GUI from popping up during Init (Wladimir J. van der Laan)
-
086d7ec2b8
Merge pull request #3457
d78f35a Explicitly ensure that wallet is unlocked in `importprivkey` (Wladimir J. van der Laan)
-
6e7792003b
Merge pull request #3453
96e5f61 extend std::exception logging in txdb.cpp (Philip Kaufmann)
-
e85e19be06
Changed Get64(.) to GetLow64()
The function Get64(.) has a bug in case the width is not divisible by 64. Since it is only ever used as Get64(0) this simply changes it to this special case. Additionally, an assert is added, and a cast to prevent a compiler error.
-
daa6b20e29
Unittests for uint256.h
Unit tests for uint256.h. The file uint160_tests.cpp is no longer needed. The ad-hoc tests which were in uint256.h are also no longer needed. The new tests achieve 100% coverage.
-
Update debian/ 4d46da20ea
-
aec55a073d
"getnetworkhashps" with defaults was yielding "0", the hashrate is not 0.
This was broken in 4c6d41b8b653ef90639b1a32f6aab0bb1cef90c5.
-
340bff34b7
ui: Better tab order in send coins entry
Pressing <tab> after entering a label now brings the focus to the address entry, instead of the row of buttons. In my experience this is more useful, as I usually want to paste an address after entering the label. The buttons are mostly useless anyway: - Choosing a previously used address should be discouraged - When I'm already using the keyboard the 'paste address' button is useless - just use the Ctrl-V. Maybe it would be an idea to remove it completely - I usually don't want to remove the entry I'm typing now! So makes sense to have it at the end of the tab chain.
-
Added new DNS seed from bitcoinstats.com. cdc11b3228
-
e8837b384d
Merge pull request #3481 from cdecker/bitcoinstats_seed
Added new DNS seed from bitcoinstats.com.
-
51947e4972
Merge pull request #3480
340bff3 ui: Better tab order in send coins entry (Wladimir J. van der Laan)
-
16403b4275
Merge pull request #3474
aec55a0 "getnetworkhashps" with defaults was yielding "0", the hashrate is not 0. (Gregory Maxwell)
-
2102ab9f5c
ui: Fix GUI initialization order
Fixes at least #3478. Splits and documents the phases: 1. Parse command-line options. These take precedence over anything else. 2. Basic Qt initialization (not dependent on parameters or configuration) 3. Application identification 4. Initialization of translations 5. Now that settings and translations are available, ask user for data directory 6. Determine availability of data directory and parse bitcoin.conf 7. URI IPC sending 8. Main GUI initialization Splits command line parsing logic from ipcSendCommandLine into ipcParseCommandLine, as isTestNet() can only be overridden in the early stages before choosing a data directory. Sending however needs to happen after choosing a data directory.
-
a867f4556b
Merge pull request #3468
4d46da2 Update debian/ (Matt Corallo)
-
ab086e0bd3
Merge pull request #3422
daa6b20 Unittests for uint256.h (Thomas Holenstein) e85e19b Changed Get64(.) to GetLow64() (Thomas Holenstein)
-
7aedb91476
Merge pull request #3401
012ca1c LoadWallet: acquire cs_wallet mutex before clearing setKeyPool (Wladimir J. van der Laan) 9569168 Document cs_wallet lock and add AssertLockHeld (Wladimir J. van der Laan) 19a5676 Use mutex pointer instead of name for AssertLockHeld (Wladimir J. van der Laan)
-
4757e92318
qt: add missing cs_wallet lock in AddressTableModel::setData
duplicate check in AddressTableModel::setData accesses wallet data structure as well as SetAddressBook without proper LOCK, fix this.
-
aaf8d15708
qt: Add missing LOCKs for locked coin functions
These don't aquire the wallet lock internally, so the caller has to do it.
-
qt: protect SetAddressBook with cs_wallet lock everywhere 28352af060
-
d31ad26550
qt: Add missing lock in WalletModel::listCoins
Another problem detected by cs_wallet lock detection (#3401).
-
37d30ec3cf
Merge pull request #3413
d31ad26 qt: Add missing lock in WalletModel::listCoins (Wladimir J. van der Laan) 28352af qt: protect SetAddressBook with cs_wallet lock everywhere (Wladimir J. van der Laan) aaf8d15 qt: Add missing LOCKs for locked coin functions (Wladimir J. van der Laan) 4757e92 qt: add missing cs_wallet lock in AddressTableModel::setData (Wladimir J. van der Laan)
-
better std::exception logging for block/undo files 7e08e29117
-
qt: Remove unused method OptionsModel::getTransactionFee 2a7201570b
-
65515c0d05
Merge pull request #3489
2a72015 qt: Remove unused method OptionsModel::getTransactionFee (Wladimir J. van der Laan)
-
7e195e8459
[Qt] massive options/settings rework (no core changes)
- add new options for database cache and script verification threads - add label which displays options that are overridden by command-line parameters - proxy settings are not applied on-the-fly anymore and require a client restart (ApplyProxySettings() was removed and was not working very well anyway) - re-work options reset and require a client shutdown (as it is much easier to do it this way without having to mess with what can be changed on-the-fly and what needs a restart anyway) - options reset now writes default values for every single option - when changing an option which requires a client restart display a 10 second warning message in statusLabel (via a QTimer) - when applying the changes via ok change that to a persistent message, which is displayed even after closing optionsdialog and re-open it, when no client restart was made - remove dialog boxes used when changing language or proxy settings - add setRestartRequired() and isRestartRequired() to OptionsModel and use the set function when updating options to signal OptionsDialog when a restart is needed - resize optionsdialog a little and add some min sizes for certain GUI elements - remove apply button from optionsdialog - save and restore optionsdialog window position - update nTransactionFee in QSettings with a set -paytxfee value when opening optionsdialog (I'm not sure about this yet, perhaps revert to not updating QSettings and just display current -paytxfee value in optionsdialog.)
-
04f58ffd9d
qt: Better status text for mined transactions
Fixes ancient issue #614.
-
d696820b45
build: Correctly put boost at end of LDADD
This fixes linking issues when statically linking (thanks @imwuzhh).
-
549e69a558
Merge pull request #3449
8b9adca Allow `-noserver` with bitcoind (Wladimir J. van der Laan)
-
6d697e9fa4
qt: Update translations
Update current translations, and add new languages: - es_MX: Spanish (Mexico) - pam: Kapampangan Also update translation process for autoconf-based build system.
-
b960fcb86a
[Qt] update bitcoin-qt.pro and assets-attribution.md
- remove unused and unmentioned file notsynced.png (we use an animation for this) - add missing coincontroldialog.ui to bitcoin-qt.pro - also unify formating in assets-attribution.md
-
13e99e463d
Merge pull request #3491
04f58ff qt: Better status text for mined transactions (Wladimir J. van der Laan)
-
eaafa23cbd
Add test for GetTime()
Test for mingw/wine issue #3494, where the upper word of time(NULL) return value gets clobbered.
-
56fce1fdbb
Upgrade gitian win32 to boost-1.55.
Fixes issue where all network activity just stops.
-
16ae1c0da1
Merge pull request #3498
eaafa23 Add test for GetTime() (Wladimir J. van der Laan)
-
c07dd453e4
Merge pull request #3432
b960fcb [Qt] update bitcoin-qt.pro and assets-attribution.md (Philip Kaufmann)
-
0d512a9ee7
gitian: Add -O2 for win32 build
In the win32 gitian descriptor the C*FLAGS are being overridden on `configure`, which causes the built-in optimization flags to be removed. Add `-O2` manually (but not `-g` as we're not doing anything with the debug information). Improves performance of win32 gitian builds. As a bonus, fixes issue #3497.
-
6b06e4fd0d
Merge pull request #3503
0d512a9 gitian: Add -O2 for win32 build (Wladimir J. van der Laan)
-
5c72e3df3c
Merge pull request #3501
56fce1f Upgrade gitian win32 to boost-1.55. (Warren Togami)
-
5b45bf400e
Merge pull request #3488
2102ab9 ui: Fix GUI initialization order (Wladimir J. van der Laan)
-
6a1bf00425
[Qt] display native dir separators in select dadatir dialog
- fixes display on Windows now \ instead of / before
-
131fb42b1b
Merge pull request #3504
6a1bf00 [Qt] display native dir separators in select dadatir dialog (Philip Kaufmann)
-
a036b796d1
Merge pull request #3347
7e195e8 [Qt] massive options/settings rework (no core changes) (Philip Kaufmann)
-
Add missing MacPorts dependencies to osx build docs f5e9d983c0
-
62e9d77496
Merge pull request #3506
f5e9d98 Add missing MacPorts dependencies to osx build docs (Michael Ford)
-
328bdb1cd6
qt5: Ensure correct link order
If optional libs don't appear in QT_LIBS, they need to be listed first for proper static linking.
-
c614bd718b
qt5: fix a build issue with osx and qtdbus
See comment in notificator.cpp for details.
-
c8ba8ef654
qt5: split out qt config and add qt5 support
Qt5 detection is a big ugly mess, but at least we can fence it off.
-
qt5: Use the info gleaned from configure for plugin importing 60dc589477
-
47ffb50533
qt5: Use QT_SELECT for debian-based distros.
At least Debian/Ubuntu use 'qtchooser' for switching between qt4/qt5 binaries. It is a wrapper for all qt tools, and calls the named tool of the default version unless overridden by the -qt= option or QT_SELECT environment variable. QT_SELECT is set by configure once the qt version has been chosen. Take for example, moc. $ which moc /usr/bin/moc $ ls -go /usr/bin/moc lrwxrwxrwx 1 9 Jul 3 21:33 /usr/bin/moc -> qtchooser $ qtchooser -print-env QT_SELECT="default" QTTOOLDIR="/usr/lib/x86_64-linux-gnu/qt4/bin" QTLIBDIR="/usr/lib/x86_64-linux-gnu" $ QT_SELECT=qt5 qtchooser -print-env QT_SELECT="qt5" QTTOOLDIR="/usr/lib/x86_64-linux-gnu/qt5/bin" QTLIBDIR="/usr/lib/x86_64-linux-gnu" $ moc -v Qt Meta Object Compiler version 63 (Qt 4.8.4) $ QT_SELECT=qt5 moc -v Qt Meta Object Compiler version 67 (Qt 5.0.1) This should be harmless elsewhere. -
8b0f608815
qt5: tests: Make sure static plugin symbols are pulled in
Since we're now properly linking against static plugins for qt binaries, we need to ensure that they're Imported properly. Without these Imports, the linker drops some of the unused linked libs, causing undefined symbols in QtCore.
-
2691cbc4b3
qt5: Force macports default include path to be searched last
Allows outside includes to take precedence. In particular, this allows for a specified Qt to be used without clashing with macports' headers.
-
qt5: fix --with-qt with no arguments 371f3f6ba5
-
qt5: fix typo causing broken selection logic 42cc96737c
-
6a0e2376a1
Merge pull request #3346
42cc967 qt5: fix typo causing broken selection logic (Cory Fields) 371f3f6 qt5: fix --with-qt with no arguments (Cory Fields) 2691cbc qt5: Force macports default include path to be searched last (Cory Fields) 8b0f608 qt5: tests: Make sure static plugin symbols are pulled in (Cory Fields) 47ffb50 qt5: Use QT_SELECT for debian-based distros. (Cory Fields) 60dc589 qt5: Use the info gleaned from configure for plugin importing (Cory Fields) c8ba8ef qt5: split out qt config and add qt5 support (Cory Fields) c614bd7 qt5: fix a build issue with osx and qtdbus (Cory Fields) 328bdb1 qt5: Ensure correct link order (Cory Fields)
-
202d853bbe
qt: Move initialization/shutdown to a thread
Move AppInit2 and Shutdown to a thread. This allows a more responsive splash screen, prevents 'process does not respond' messages from the window system and will allow for showing a user friendly window while shutting down.
-
55fe4de960
qt: Show window while shutting down
Makes it clear to the user that the application is still wrapping up and the computer should not be turned off until it is finished.
-
35ecf854c0
qt: Remove global references in bitcoin.cpp
Remove the need for global references `guiref` and `splashref` by making the BitcoinGUI and SplashScreen classes register for the UI interface signals themselves.
-
9a2305a1b3
qt: Stop shutdown detection timer during shutdown
Stop the shutdown timer from exiting the main loop when shutdown is already in progress. Fixes seeming hanging window after typing 'stop' in debug console. Also hide the debug console during shutdown as it is useless without a core to connect to.
-
054be736d4
Merge pull request #3493
9a2305a qt: Stop shutdown detection timer during shutdown (Wladimir J. van der Laan) 35ecf85 qt: Remove global references in bitcoin.cpp (Wladimir J. van der Laan) 55fe4de qt: Show window while shutting down (Wladimir J. van der Laan) 202d853 qt: Move initialization/shutdown to a thread (Wladimir J. van der Laan)
-
ec41342e3d
build: pass correct defs and include path to moc
To make sure the right slots are generated, MOC needs -DHAVE_CONFIG_H and correct include path to include bitcoin-config.h.
-
b7f4b6d35d
GUI for --disable-wallet compiles and -disablewallet mode
There is not much in the GUI to be done without wallet, though it's possible to change options, watch the sync process, and use the debug console. So embed the debug console in the main window.
-
061aff4c46
Merge pull request #3392
b7f4b6d GUI for --disable-wallet compiles and -disablewallet mode (Wladimir J. van der Laan) ec41342 build: pass correct defs and include path to moc (Wladimir J. van der Laan)
-
5a407bd095
makefile.am: split long lines into one file per line
This makes it easier to read diffs. Cosmetic change to build system only.
-
GUI: Fix design in overview page 9b146cd3ca
-
c037531d69
small headers ordering cleanup
- keep headers in alphabetical order - fix Makefile.am (2 files in 1 line - leftover) - remove some spaces etc.
-
dc64c3c374
Merge pull request #3510
c037531 small headers ordering cleanup (Philip Kaufmann)
-
[Qt] guard bitcoin-config.h and remove dublicated help message code 245a6ab1ae
-
04aa828728
[Qt] don't regenerate autostart link on every client startup
- allows users to add additional paramaters via the autostart link - related to #2197
-
Store orphan blocks in serialized form da0fecffa7
-
d464edfb8c
[Qt] fix alphabetical ordering in Makefile.am
- also change to 1 file per line for more stuff in Makefile.am
-
b68c618c6d
Merge pull request #3507
9b146cd GUI: Fix design in overview page (Cozz Lovan)
-
0a4fefe18f
Merge pull request #3511
245a6ab [Qt] guard bitcoin-config.h and remove dublicated help message code (Philip Kaufmann)
-
0e469b5167
Merge pull request #3513
d464edf [Qt] fix alphabetical ordering in Makefile.am (Philip Kaufmann)
-
7a29fb5940
Tweak linearize.py to give more flexibility
Add the ability to start at a non-zero height, and allow for appending to an existing file.
-
be2fb2d603
Merge pull request #3518 from Michagogo/linearize-start-value
Tweak linearize.py to give more flexibility
-
67d60f7031
build: fix MacOSX build after ec41342
Fix regression introduced in ec41342. Also use a less ugly solution, by defining the value of `MOC_DEFS` in the configure script instead of `Makefile.include`.
-
a7973c9b6b
Merge pull request #3524
67d60f7 build: fix MacOSX build after ec41342 (Wladimir J. van der Laan)
-
15570cc9aa
src/leveldb/Makefile is ignored?
remove the "-" in leveldb-* to include src/leveldb/Makefile
-
f10b2d70d0
qt: use series of pngs for spinner
Use a series of .png frames for the spinner instead of a .mng. `mng` is an obscure image format and is not built by default into Qt5. This appears to improve the crispness of the spinner as well. Does not noticably increase the size (still ~27k) and the code is not more complicated either.
-
66a8829a33
qt: Minor message updates
Used sending/receiving addresses -> Sending/receiving addresses Previously requested payments -> Requested payments (idea from @cozz in #3521)
-
f126973fd0
Merge pull request #3374
bd70562 [Qt] add messages when handling local payment request files (Philip Kaufmann)
-
c7930c859e
Merge pull request #3528
66a8829 qt: Minor message updates (Wladimir J. van der Laan)
-
qt: English translation update f087ce8891
-
b1347d5565
Merge pull request #3532
f087ce8 qt: English translation update (Wladimir J. van der Laan)
-
266921e70f
Merge pull request #3516 from sipa/serorphans-head
Store orphan blocks in serialized form
-
e4f041bdd1
Merge pull request #3525
15570cc src/leveldb/Makefile is ignored? (harry)
-
dbafb99472
Merge pull request #3526
f10b2d7 qt: use series of pngs for spinner (Wladimir J. van der Laan)
-
qt: Update copyright year in about dialog to 2014 5bab55898d
-
2f158dfc93
build: Update the other win32 deps
- miniupnpc-1.8 - openssl-1.0.1e - zlib-1.2.8 - libpng-1.6.8 - qrencode-3.4.3
-
build: upgrade Qt used by windows build to 5.2.0 1e3abb4e3d
-
qt: Update remaining "The Bitcoin Core Developers" b26de9d951
-
build: use Ubuntu 12.04 for linux gitian build 279af1a2af
-
update copyright year to 2014 8c20bbbed9
-
[Qt] add missing lock in walletmodel 57d8e3f88f
-
[Qt] 2 minor translation changes 81bad8b386
-
7fb5894b4c
Merge pull request #3537
8c20bbb update copyright year to 2014 (Philip Kaufmann)
-
[Qt] small paymentserver header cleanup c704532294
-
b0e8c4b0b9
Merge pull request #3540
57d8e3f [Qt] add missing lock in walletmodel (Cozz Lovan)
-
6b5fbc9073
Merge pull request #3541
c704532 [Qt] small paymentserver header cleanup (Philip Kaufmann)
-
1aac1448de
Merge pull request #3538
81bad8b [Qt] 2 minor translation changes (Philip Kaufmann)
-
f8b48ed297
Merge pull request #3426
16ec904 Don't create empty transactions when reading corrupted wallet (Wladimir J. van der Laan)
-
720731d281
Update configure.ac
Added ubuntu 13.10 and libboost1.54-all-dev incompatibility instruction to the existing no boost_sleep warning.
-
69843c8b4e
Update build-unix.md
Added incompatibility and instruction regarding Ubuntu 13.10 and libboost1.54-all-dev
-
f4bb12eecc
doc: bump boost version in release-process
This was forgotten in #3501.
-
04257151b1
gitian: add explicit dependency build for linux
Create a dependency file per architecture: - bitcoin-deps-linux32-gitian-r1.tar.gz - bitcoin-deps-linux64-gitian-r1.tar.gz
-
8c31f037b1
Merge pull request #3527 from laanwj/2014_01_gitian_win32_qt5
build: update win32 deps
-
4b4b578cb3
Merge pull request #3536
0425715 gitian: add explicit dependency build for linux (Wladimir J. van der Laan) 279af1a build: use Ubuntu 12.04 for linux gitian build (Wladimir J. van der Laan)
-
f4e72bf8d2
Make gitian builds consistent across platforms
Change Linux deps to use a zip archive rather than a gzipped tarball to match win32 Rename Linux descriptor to gitian-linux.yml to match win32
-
Added automake to the macports depdency list as it was required to complete the autogen.sh step as it required aclocal (which isn't included in recent versions of xcode). 8d31e614e8
-
417aad4a38
Merge pull request #3546
f4e72bf Make gitian builds consistent across platforms (Micha)
-
8da2b3316c
Merge pull request #3547
8d31e61 Added automake to the macports depdency list as it was required to complete the autogen.sh step as it required aclocal (which isn't included in recent versions of xcode). (Scott Willeke)
-
5753824171
Merge pull request #3542
69843c8 Update build-unix.md (Christopher Latham) 720731d Update configure.ac (Christopher Latham)
-
08ede8ef5e
Merge pull request #3512
04aa828 [Qt] don't regenerate autostart link on every client startup (Philip Kaufmann)
-
6c19ca1f92
Merge pull request #3490
7e08e29 better std::exception logging for block/undo files (Philip Kaufmann)
-
Merge src/leveldb changes: temporarily revert to writing .sst files. b9d384a45d
-
wtogami commented at 1:46 PM on January 18, 2014: contributor
ACK
-
BitcoinPullTester commented at 2:14 PM on January 18, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b9d384a45dfe9f258a81aee7341b32dcd712a494 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- laanwj referenced this in commit fb766b640c on Jan 18, 2014
- laanwj merged this on Jan 18, 2014
- laanwj closed this on Jan 18, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors