Merge src/leveldb change: temporarily revert to writing .sst files. #3555

pull sipa wants to merge 5109 commits into bitcoin:master from sipa:leveldbsst changing 728 files +307400 −12
  1. sipa commented at 1:32 PM on January 18, 2014: member

    No description provided.

  2. Merge pull request #3320 from laanwj/2013_11_cli_split
    bitcoin-cli: remove unneeded dependencies (only minor code movement)
    cf74e8cb5e
  3. [Qt] small notificator and style changes
    - remove default arguments for notificator
    - re-order some calls to use same ordering in Qt files
    - style police changes (spaces, comments and such)
    ccd1372dd0
  4. Merge pull request #3285
    d3207b6 [Qt] coin-control features GUI cleanup 3 (Philip Kaufmann)
    834e14e [Qt] coin-control features GUI cleanup 2 (Philip Kaufmann)
    f15bd3c96f
  5. Payment request URI syntax changed, from request=... to r=...
    BIP 72 was changed to save six bytes in bitcoin: URIs.
    1e01f7c506
  6. qt: use deleteLater to remove send entries
    Use deleteLater() instead of delete, as it is not allowed
    to delete widgets directly in an event handler.
    Should solve the MacOSX random crashes on send with coincontrol.
    6c98cca9e4
  7. Merge pull request #3355
    6c98cca qt: use deleteLater to remove send entries (Wladimir J. van der Laan)
    00cfc9f074
  8. Move HelpExample* from rpcwallet to rpcserver
    General functions used throughout the RPC framework
    don't belong in rpcwallet.
    bbb093652e
  9. Move getinfo to rpcnet.cpp
    Where to place `getinfo` is a difficult issue
    as it shows information from the wallet, net and
    block chain. However, I moved it out of rpcwallet
    as the command needs also to be available without
    wallet.
    991685d3dc
  10. Delimit code with #ifdef ENABLE_WALLET
    Delimit all code that uses the wallet functions
    in implementation files that conditionally use the wallet.
    48ba56cdfd
  11. Move CAddrDB frrom db to net
    This was a leftover from the times in which
    peers.dat depended in BDB.
    
    Other functions in db.cpp still depend on BerkelyDB,
    to be able to compile without BDB this (small)
    functionality needs to be moved to another file.
    d004d7279f
  12. Add --disable-wallet option to build system
    Make it possible to build Bitcoin without wallet
    (and thus without BDB) so that it only functions as node.
    4f9e993bc9
  13. Update build-unix.md to mention --disable-wallet
    Mention the new --disable-wallet mode.
    Also, correct the BDB entry in the dependencies table.
    ae6ea5a6fa
  14. Move CCryptoKeyStore to crypter.cpp
    This breaks the dependency on crypter for disable-wallet builds.
    829c920387
  15. Split off rpc_wallet_tests
    Split wallet tests from other RPC tests.
    Now no #ifdef ENABLE_WALLET are needed anymore in either file.
    5094f8d46f
  16. Prevent empty transactions from being added to vtxPrev
    CWalletTx::AddSupportingTransactions() was adding empty transaction
    to vtxPrev in some cases. Skip over these.
    
    Part one of the solution to #3190. This prevents invalid vtxPrev from
    entering the wallet, but not current ones being transmitted.
    d3ef9b00ec
  17. Refuse to retransmit transactions without vins
    Versions of bitcoin before 0.8.6 have a bug that inserted
    empty transactions into the vtxPrev in the wallet, which will cause the node to be
    banned when retransmitted, hence add a check for !tx.vin.empty()
    before RelayTransaction.
    4ef92a9067
  18. Merge pull request #3357
    4ef92a9 Refuse to retransmit transactions without vins (Wladimir J. van der Laan)
    80ca273b7f
  19. Merge pull request #3356
    d3ef9b0 Prevent empty transactions from being added to vtxPrev (Wladimir J. van der Laan)
    b1961523f1
  20. fix typo in rpcnet.cpp 38cbeab1ff
  21. Merge pull request #3359
    38cbeab fix typo in rpcnet.cpp (Philip Kaufmann)
    ac57a2320f
  22. Change release-process.md to sign release tags cc75306ceb
  23. Merge pull request #3362 from Michagogo/signed-tags
    Change release-process.md to sign release tags
    d6d12f932d
  24. Merge pull request #3353
    1e01f7c Payment request URI syntax changed, from request=... to r=... (Gavin Andresen)
    b4297c8fff
  25. [Qt] misc PaymentServer changes (e.g. changes to eventFilter())
    - make eventFilter() private and pass events on to QObject::eventFilter()
      instead of just returning false
    - re-work paymentservertest.cpp to correctly handle the event test
      after the above change (rewrite test_main to allow usage of
      QCoreApplication:: in the tests)
    - delete socket when we were unable to connect in ipcSendCommandLine()
    - show a message to the user if we fail to start-up (instead of just a
      debug.log entry)
    - misc small comment changes
    4cf3411056
  26. Merge pull request #3254
    4cf3411 [Qt] misc PaymentServer changes (e.g. changes to eventFilter()) (Philip Kaufmann)
    9ac11a4e1e
  27. Restore hex to getrawtransaction vout scriptPubkey.
    Commit be066fad accidentally removed the hex field.
    This gets in the way of doing offline signing.
    
    (credit belongs to sipa for actually looking for the
     cause instead of being lazy like me and just shrugging
     and writing the scriptpubkey from the asm.)
    a702a0b61d
  28. Merge pull request #3365 from gmaxwell/hexify
    Restore hex to getrawtransaction vout scriptPubkey.
    fbbed19b78
  29. Merge pull request #3332
    5094f8d Split off rpc_wallet_tests (Wladimir J. van der Laan)
    829c920 Move CCryptoKeyStore to crypter.cpp (Wladimir J. van der Laan)
    ae6ea5a Update build-unix.md to mention --disable-wallet (Wladimir J. van der Laan)
    4f9e993 Add --disable-wallet option to build system (Wladimir J. van der Laan)
    d004d72 Move CAddrDB frrom db to net (Wladimir J. van der Laan)
    48ba56c Delimit code with #ifdef ENABLE_WALLET (Wladimir J. van der Laan)
    991685d Move getinfo to rpcnet.cpp (Wladimir J. van der Laan)
    bbb0936 Move HelpExample* from rpcwallet to rpcserver (Wladimir J. van der Laan)
    05e27c6641
  30. Merge pull request #3322
    26d1b65 src/Makefile.am: Simplify clean of leveldb (Josh Triplett)
    a26a367 configure.ac: Check for miniupnpc headers, not just -lminiupnpc (Josh Triplett)
    82ccb05 autogen.sh: Stop passing --verbose to autoreconf (Josh Triplett)
    e12dafd autogen.sh: Use long options to autoreconf, for self-documentation (Josh Triplett)
    19b9add autogen.sh: Support running from outside the source directory (Josh Triplett)
    97d285a autogen.sh: Use set -e to fail if any command fails (Josh Triplett)
    f80b723 autogen.sh: Add a /bin/sh shebang. (Josh Triplett)
    6893d74e15
  31. Merge pull request #3348
    ccd1372 [Qt] small notificator and style changes (Philip Kaufmann)
    70370ae502
  32. Add main-specific node state b2864d2fb3
  33. Add rpc command 'getunconfirmedbalance' to obtain total unconfirmed balance
    Conflicts:
    	src/rpcserver.cpp
    6027b460e4
  34. Add ThreadGetMyExternalIP to net thread group
    Fixes #3372 -- crash at shutdown.
    80ecf6702a
  35. Merge pull request #3276 from sipa/nodestate
    Add main-specific node state & move ban score
    7202d9d9bf
  36. Allow mining RPCs with --disable-wallet
    The following mining-related RPC calls don't use the wallet:
    
    - getnetworkhashps
    - getmininginfo
    - getblocktemplate
    - submitblock
    
    Enable them when compiling with --disable-wallet.
    4a85e06750
  37. Move internal miner functionality together acfa03337e
  38. Re-enable miner tests in --disable-wallet mode
    Use a fixed script instead of a CReserveKey from the wallet.
    This does not affect the functionality or result of the tests as they never
    check the state of the wallet in the first place.
    fbc7a96d03
  39. some string and indentation updates in init/rpcclient b6aafca03d
  40. Merge pull request #3373
    80ecf67 Add ThreadGetMyExternalIP to net thread group (Gavin Andresen)
    7266bb1bdc
  41. cleanup includes in rpcnet.cpp fdbdb7f345
  42. [Qt] misc small Mac related changes/cleanups
    - cleanup Info.plist.in and specify high DPI mode enable command as per
      http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-ios-and-x11/
    - move setting of QApplication::setAttribute() to bitcoin.cpp and add
      attribute for enabling use of high DPI pixmaps for Qt >= 5.1
    - add missing setWindowTitle() on Mac
    - cleanup Mac / non-Mac setup in bitcoingui.cpp
    84f8551f3a
  43. Merge pull request #3297
    84f8551 [Qt] misc small Mac related changes/cleanups (Philip Kaufmann)
    6694f4a7a2
  44. rpcwallet: use EnsureWalletIsUnlocked() where possible
    - replaces a pwalletMain->IsLocked() check
    - in keypoolrefill init kpSize to 0 as we have the logic to determine max
      kpSize in pwalletMain->TopUpKeyPool() anyway
    f914c7a1a4
  45. Merge pull request #3178
    f914c7a rpcwallet: use EnsureWalletIsUnlocked() where possible (Philip Kaufmann)
    20a3c80790
  46. Merge pull request #3207
    666893b qt: keep a list of requested payments (Wladimir J. van der Laan)
    955787f83f
  47. Fix infinite loop with LogPrint on Windows
    Running -printtodebugger -debug (or -debug=lock),
    compiled with -DDEBUG_LOCKORDER would infinite loop
    on Windows because every critical section lock/unlock
    triggers a LogPrint.
    
    Solution is to use the raw boost mutex instead of a CCriticalSection.
    962b1cf441
  48. Use thread-local storage for LogPrint(category...)
    This prevents crashes at shutdown where a global destructor
    calls LogPrint(category...) after mapMultiArgs has been
    deleted.
    0b238b2786
  49. Merge pull request #3368 from laanwj/2013_11_disable_wallet_mining
    Allow mining RPCs with --disable-wallet
    d47bbbd261
  50. Add protobuf-compiler dependency package for debian
    Fixes #3361
    b9c3416723
  51. Merge pull request #3378
    b9c3416 Add protobuf-compiler dependency package for debian (Wladimir J. van der Laan)
    fb96e28b29
  52. Release process: add section about announcing new release 4f99b1601b
  53. [Qt] add messages when handling local payment request files
    - important for the open URI dialog to give users feedback
      when a file is invalid etc.
    bd70562f66
  54. Merge pull request #3350
    fdbdb7f cleanup includes in rpcnet.cpp (Philip Kaufmann)
    b6aafca some string and indentation updates in init/rpcclient (Philip Kaufmann)
    6939a0d50e
  55. Add tests for correct and incorrect order of signatures for a multisig
    (P2SH)
    3e01c00f42
  56. Update build-osx.md 9392924d0d
  57. Merge pull request #3389 from regergregregerrge/patch-1
    Update build-osx.md
    ef20293c51
  58. Merge pull request #3379
    4f99b16 Release process: add section about announcing new release (Wladimir J. van der Laan)
    69127034c3
  59. [Qt] fix possibilty to delete last sendcoins entry
    - hide the entry about to be deleted, and if it is the last entry add a
      new one, so that we always have one entry in our list
    24646ee76f
  60. [Qt] fix RecentRequestsTableModel function ambiuguity
    - fixes a compiler ambiguity error with ::createIndex() called in
      RecentRequestsTableModel::index()
    - also add some Q_UNUSED() macros
    7df07b3f45
  61. Merge pull request #3382
    24646ee [Qt] fix possibilty to delete last sendcoins entry (Philip Kaufmann)
    5e47c2b70a
  62. build: fix syntax error on older m4/autoconf.
    Fixes #3358. This affects preinstalled autotools on osx 10.6.
    b878b763cb
  63. Use 'make check' instead of 'make test' 3f2c6f8654
  64. Merge pull request #3395 from ldenman/patch-2
    Use 'make check' instead of 'make test'
    c4880e0172
  65. Merge pull request #3393 from theuni/build-10.6
    build: fix syntax error on older m4/autoconf.
    fb34be6d59
  66. Merge src/leveldb changes for LevelDB 1.15 ed873a301e
  67. build: fix detection of boost libs on multi-arch distros
    Fixes #3219.
    efdfee423f
  68. docs: remove workaround instructions now that the problem is fixed 952fe2ef32
  69. Merge pull request #3407
    952fe2e docs: remove workaround instructions now that the problem is fixed (Cory Fields)
    efdfee4 build: fix detection of boost libs on multi-arch distros (Cory Fields)
    d670cdd698
  70. Merge pull request #3326
    ad898b4 Increase default -blockmaxsize/prioritysize to 750K/50K (Gavin Andresen)
    150771c4f3
  71. Merge pull request #3387
    3e01c00 Add tests for correct and incorrect order of signatures for a multisig (P2SH) (Tamas Blummer)
    666225f687
  72. Rebrand to `Bitcoin Core`
    Only messages for now, executable names and other file names
    can be changed later if necessary and safe.
    
    Do not do an all-sweeping change. Some occurences of Bitcoin-Qt need to
    be kept:
    
    - Applicationname: this is used to determine the registry entry names,
      we don't want to lose settings over a silly name change.
    - Where it refers to the executable name instead of the product name.
    22f0135df0
  73. update help for -blockmaxsize and blockprioritysize
    - was left out in #3326
    a9a37c8bb5
  74. Merge pull request #3409
    a9a37c8 update help for -blockmaxsize and blockprioritysize (Philip Kaufmann)
    5e2fb330fd
  75. fixed documetation on hardening flags 08b93f9a65
  76. Merge pull request #3411
    08b93f9 fixed documetation on hardening flags (HaltingState)
    6bfaf2ac37
  77. add new RPC implementation file `rpcmisc.cpp` 652e156951
  78. Move `getinfo` from rpcnet to rpcmisc
    `getinfo` is a general info method which shows information
    from multiple sources, it doesn't belong in rpcnet.cpp or
    any of the other current RPC implementation files.
    16bc9aaf8a
  79. Move `settxfee` from rpcblockchain to rpcwallet
    `settxfee` only affects the wallet, not the block chain.
    a943bde6f0
  80. Move `nTransactionFee` from main.cpp to wallet.cpp
    Transaction fee is only used by the wallet.
    No need for it to be in main.cpp.
    cd7fa8bb43
  81. Move `validateaddress` from rpcwallet to rpcmisc
    Enables it in --disable-wallet compiles.
    Delimit wallet-using part using #ifdef ENABLE_WALLET.
    452955f5be
  82. Move `createmultisig` from rpcwallet to rpcmisc
    Enables it in --disable-wallet compiles.
    723a03d2de
  83. Move `verifymessage` from rpcwallet to rpcmisc
    Enables it in --disable-wallet compiles.
    c3a7f516e7
  84. Remove unused ThreadSafeHandleURI from ui_interface 37e67d37c1
  85. Remove unused ThreadSafeAskFee from ui_interface
    ThreadSafeAskFee is effectively unused. It is only called
    when the fAskFee parameter on SendMoney or SendMoneyToDestination
    is true, which never happens. Remove it.
    ca2c83da50
  86. Merge pull request #3377
    0b238b2 Use thread-local storage for LogPrint(category...) (Gavin Andresen)
    962b1cf Fix infinite loop with LogPrint on Windows (Gavin Andresen)
    8a7606f35b
  87. Remove -logtodebugger
    `-logtodebugger` is a strange, obscure, WIN32-only (mostly MSVC) thing.
    Let's clean up the options a bit get rid of it.
    
    test_bitcoin was using fLogToDebugger as a way to prevent logging to
    debug.log. For this, add a boolean (not exposed as option) fLogToDebugLog that
    defaults to true and is disabled in the tests.
    9e9056cd1a
  88. Fix unit test error on OSX 10.9 using Apple LLVM v5.0.
    Before the fix, there were 6 errors such as :
    serialize_tests.cpp:77: error in "noncanonical": incorrect exception std::ios_base::failure is caught
    
    It turns out that ex.what() returns following string instead of "non-canonical ReadCompactSize()"
    "non-canonical ReadCompactSize(): unspecified iostream_category error"
    
    After the fix, unit test passed.
    
    The test ran using Apple LLVM v5.0 on OSX 10.9 and the unit test error happened because of different error messages by different compilers.
    
    g++ --version on my development environment.
    
    ```
    Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
    Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn)
    Target: x86_64-apple-darwin13.0.0
    Thread model: posix
    ```
    bccd5324ab
  89. qt: use GUIUtil::dateTimeStr in coincontrol 93a5d0bb98
  90. Merge pull request #3421
    93a5d0b qt: use GUIUtil::dateTimeStr in coincontrol (Wladimir J. van der Laan)
    d05ce63c98
  91. Merge pull request #3420
    bccd532 Fix unit test error on OSX 10.9 using Apple LLVM v5.0. (Kangmo)
    a5a65bbc90
  92. Improve unit test code not to compare with explanatory messages for each platform.
    Instead, use have an exception object to check if the string returned by what() on the raised exception matches the string returned by what() on the expected exception instance.
    This way, we do not need to list all different possible explanatory strings for different platforms in the test code, and make it simple. (The idea is by Cory Fields.)
    0205abd83d
  93. Merge pull request #3423
    0205abd Improve unit test code not to compare with explanatory messages for each platform. Instead, use have an exception object to check if the string returned by what() on the raised exception matches the string returned by what() on the expected exception instance. This way, we do not need to list all different possible explanatory strings for different platforms in the test code, and make it simple. (The idea is by Cory Fields.) (Kangmo)
    3d7c66d75d
  94. qt: status WalletModel::Aborted is no longer used
    Aborting transactions happens in the GUI now as it should,
    not the backend.
    4a61c39456
  95. Seperate out wallet options in help message
    Seperate out the wallet options in HelpMessage, and
    don't show them if compiled with --disable-wallet.
    
    Also add documentation for `-disablewallet` option.
    06eb2f215b
  96. Merge pull request #3408
    22f0135 Rebrand to `Bitcoin Core` (Wladimir J. van der Laan)
    2ed38d11a8
  97. qt: Update English language file for translators 88ba2643f0
  98. Merge pull request #3425
    88ba264 qt: Update English language file for translators (Wladimir J. van der Laan)
    93a7861d71
  99. Don't create empty transactions when reading corrupted wallet
    The current transaction loading code is not exception safe.
    An exception during deserialization causes an empty transaction
    to be left behind in the wallet.
    
    Fix this by building the transaction separately and adding
    it only to the wallet at the end.
    
    Fixes #3333.
    16ec9044d1
  100. qt: Prevent non-functional GUI from popping up during Init
    When a InitError or InitWarning happens, the
    GUI pops up but is unusable (until Init finishes).
    
    This is caused by showNormalIfMinimized. Add a message
    flag to skip this call for Init errors or warnings.
    1ad26362c9
  101. Fix typo in unit-tests.md ba4ceb15d6
  102. Merge pull request #3430 from ldenman/patch-1
    Fix typo in unit-tests.md
    3743b80528
  103. Fix typos in spendfrom README 131c3db8fb
  104. some more small re-branding changes (Bitcoin Core) 46469d0f86
  105. Merge pull request #3434
    46469d0 some more small re-branding changes (Bitcoin Core) (Philip Kaufmann)
    8f5fd94497
  106. Merge pull request #3431
    131c3db Fix typos in spendfrom README (Lake Denman)
    a549842499
  107. [Qt] style-police, add missing license headers
    - add missing license headers in Mac files
    - small code formating cleanups
    6c1bf199ca
  108. Rebrand README.md
    How could I forgot this file...
    9c6546c90e
  109. Merge pull request #3405
    55c6890 Squashed 'src/leveldb/' changes from 936b461..e991315 (Pieter Wuille)
    cf920b657d
  110. Merge pull request #3435
    9c6546c Rebrand README.md (Wladimir J. van der Laan)
    5ac8b6eeaa
  111. Fix heading in README.md c8af33aa75
  112. Merge pull request #3381
    7df07b3 [Qt] fix RecentRequestsTableModel function ambiuguity (Philip Kaufmann)
    97203994a4
  113. Merge pull request #3424
    06eb2f2 Seperate out wallet options in help message (Wladimir J. van der Laan)
    03d9dd47f6
  114. Merge pull request #3415
    4a61c39 qt: status WalletModel::Aborted is no longer used (Wladimir J. van der Laan)
    ca2c83d Remove unused ThreadSafeAskFee from ui_interface (Wladimir J. van der Laan)
    37e67d3 Remove unused ThreadSafeHandleURI from ui_interface (Wladimir J. van der Laan)
    57fdd68aac
  115. Merge pull request #3433
    6c1bf19 [Qt] style-police, add missing license headers (Philip Kaufmann)
    a5824bb3c6
  116. Remove ui_interface ThreadSafeAskFee residue
    Missed these in ca2c83d (#3415).
    636a42bd0e
  117. Use mutex pointer instead of name for AssertLockHeld
    This makes it useable for non-global locks such as the wallet and
    keystore locks.
    19a5676280
  118. Document cs_wallet lock and add AssertLockHeld
    Add locking assertions to wallet to all methods that
    access internal fields and do not aquire the cs_wallet mutex.
    956916806a
  119. LoadWallet: acquire cs_wallet mutex before clearing setKeyPool
    Make the function mutex-aware, to prevent having to lock cs_wallet
    at the call site in Init.
    012ca1c9e4
  120. Merge pull request #3412
    c3a7f51 Move `verifymessage` from rpcwallet to rpcmisc (Wladimir J. van der Laan)
    723a03d Move `createmultisig` from rpcwallet to rpcmisc (Wladimir J. van der Laan)
    452955f Move `validateaddress` from rpcwallet to rpcmisc (Wladimir J. van der Laan)
    cd7fa8b Move `nTransactionFee` from main.cpp to wallet.cpp (Wladimir J. van der Laan)
    a943bde Move `settxfee` from rpcblockchain to rpcwallet (Wladimir J. van der Laan)
    16bc9aa Move `getinfo` from rpcnet to rpcmisc (Wladimir J. van der Laan)
    652e156 add new RPC implementation file `rpcmisc.cpp` (Wladimir J. van der Laan)
    285cf7a1a6
  121. Make bitcoin compile without wallet if "db_cxx.h" is not present
    Moved includes of "db.h" into #ifdef ENABLE_WALLET blocks or remove
    them.
    df840de5da
  122. qt: Make sure overviewpage button is pressed at startup
    Due to walletframe changes, the overview page button is no longer
    automatically selected at startup even though the overview page is shown.
    d2b6de031f
  123. Merge pull request #3438
    d2b6de0 qt: Make sure overviewpage button is pressed at startup (Wladimir J. van der Laan)
    cc661b4d7f
  124. qt: Treat regtest as testnet
    No need to do anything special in the GUI for regtest mode,
    but do treat it at testnet not mainnet to prevent confusion.
    2ea980a77c
  125. Merge pull request #3437
    2ea980a qt: Treat regtest as testnet (Wladimir J. van der Laan)
    326b5bb9d0
  126. Merge pull request #3369
    6027b46 Add rpc command 'getunconfirmedbalance' to obtain total unconfirmed balance (Michael Bauer)
    23981b1f47
  127. Merge pull request #3416
    9e9056c Remove -logtodebugger (Wladimir J. van der Laan)
    f498d43ee2
  128. init: add better formating for some command-line options 3c955993a4
  129. [Qt] coin control change address handling update
    - re-work change address handling so that default is CNoDestination(),
      until a verified and known change address was entered (easier code flow)
    - add a missing NULL pointer check for adresstablemodel
    - add a missing text when opening coin control address selection for
      priority and ensure the label is black
    - add a missing . at the end of a sentence
    3380713af5
  130. Merge pull request #3439
    3c95599 init: add better formating for some command-line options (Philip Kaufmann)
    9e508b5588
  131. Allow `-noserver` with bitcoind
    Allow running bitcoind without server.
    
    - Default to -server mode (of course) for bitcoind with SoftSetBoolArg
    - Remove fForceServer argument from AppInit2
    - Move fDaemon to a static variable in bitcoind
    8b9adca446
  132. Merge pull request #3391
    3380713 [Qt] coin control change address handling update (Philip Kaufmann)
    365350140a
  133. qt: make wallet test consistent
    Add a function `WaitBlocks` to wait for blocks to propagate to all three
    nodes, and use this instead of waiting a fixed time of one second.
    
    Fixes #3445.
    5fe19d640e
  134. extend std::exception logging in txdb.cpp 96e5f61d6c
  135. Merge pull request #3451
    5fe19d6 qt: make wallet test consistent (Wladimir J. van der Laan)
    f46babc8c8
  136. Explicitly ensure that wallet is unlocked in `importprivkey`
    This makes for a more useful error reply (fixes #957).
    d78f35a909
  137. Merge pull request #3427
    1ad2636 qt: Prevent non-functional GUI from popping up during Init (Wladimir J. van der Laan)
    362755d018
  138. Merge pull request #3457
    d78f35a Explicitly ensure that wallet is unlocked in `importprivkey` (Wladimir J. van der Laan)
    086d7ec2b8
  139. Merge pull request #3453
    96e5f61 extend std::exception logging in txdb.cpp (Philip Kaufmann)
    6e7792003b
  140. Changed Get64(.) to GetLow64()
    The function Get64(.) has a bug in case the width is not divisible by 64.
    Since it is only ever used as Get64(0) this simply changes it to this
    special case. Additionally, an assert is added, and a cast to prevent
    a compiler error.
    e85e19be06
  141. Unittests for uint256.h
    Unit tests for uint256.h. The file uint160_tests.cpp is no longer
    needed. The ad-hoc tests which were in uint256.h are also no longer
    needed. The new tests achieve 100% coverage.
    daa6b20e29
  142. Update debian/ 4d46da20ea
  143. "getnetworkhashps" with defaults was yielding "0", the hashrate is not 0.
    This was broken in 4c6d41b8b653ef90639b1a32f6aab0bb1cef90c5.
    aec55a073d
  144. ui: Better tab order in send coins entry
    Pressing <tab> after entering a label now brings the focus to the
    address entry, instead of the row of buttons. In my experience this
    is more useful, as I usually want to paste an address after
    entering the label.
    
    The buttons are mostly useless anyway:
    
    - Choosing a previously used address should be discouraged
    
    - When I'm already using the keyboard the 'paste address' button is
    useless - just use the Ctrl-V. Maybe it would be an idea to remove it
    completely
    
    - I usually don't want to remove the entry I'm typing now! So makes
    sense to have it at the end of the tab chain.
    340bff34b7
  145. Added new DNS seed from bitcoinstats.com. cdc11b3228
  146. Merge pull request #3481 from cdecker/bitcoinstats_seed
    Added new DNS seed from bitcoinstats.com.
    e8837b384d
  147. Merge pull request #3480
    340bff3 ui: Better tab order in send coins entry (Wladimir J. van der Laan)
    51947e4972
  148. Merge pull request #3474
    aec55a0 "getnetworkhashps" with defaults was yielding "0", the hashrate is not 0. (Gregory Maxwell)
    16403b4275
  149. ui: Fix GUI initialization order
    Fixes at least #3478.
    
    Splits and documents the phases:
    1. Parse command-line options. These take precedence over anything else.
    2. Basic Qt initialization (not dependent on parameters or configuration)
    3. Application identification
    4. Initialization of translations
    5. Now that settings and translations are available, ask user for data directory
    6. Determine availability of data directory and parse bitcoin.conf
    7. URI IPC sending
    8. Main GUI initialization
    
    Splits command line parsing logic from ipcSendCommandLine into
    ipcParseCommandLine, as isTestNet() can only be overridden in the early
    stages before choosing a data directory. Sending however needs to happen
    after choosing a data directory.
    2102ab9f5c
  150. Merge pull request #3468
    4d46da2 Update debian/ (Matt Corallo)
    a867f4556b
  151. Merge pull request #3422
    daa6b20 Unittests for uint256.h (Thomas Holenstein)
    e85e19b Changed Get64(.) to GetLow64() (Thomas Holenstein)
    ab086e0bd3
  152. Merge pull request #3401
    012ca1c LoadWallet: acquire cs_wallet mutex before clearing setKeyPool (Wladimir J. van der Laan)
    9569168 Document cs_wallet lock and add AssertLockHeld (Wladimir J. van der Laan)
    19a5676 Use mutex pointer instead of name for AssertLockHeld (Wladimir J. van der Laan)
    7aedb91476
  153. qt: add missing cs_wallet lock in AddressTableModel::setData
    duplicate check in AddressTableModel::setData accesses
    wallet data structure as well as SetAddressBook without proper LOCK, fix this.
    4757e92318
  154. qt: Add missing LOCKs for locked coin functions
    These don't aquire the wallet lock internally, so the caller has to do
    it.
    aaf8d15708
  155. qt: protect SetAddressBook with cs_wallet lock everywhere 28352af060
  156. qt: Add missing lock in WalletModel::listCoins
    Another problem detected by cs_wallet lock detection (#3401).
    d31ad26550
  157. Merge pull request #3413
    d31ad26 qt: Add missing lock in WalletModel::listCoins (Wladimir J. van der Laan)
    28352af qt: protect SetAddressBook with cs_wallet lock everywhere (Wladimir J. van der Laan)
    aaf8d15 qt: Add missing LOCKs for locked coin functions (Wladimir J. van der Laan)
    4757e92 qt: add missing cs_wallet lock in AddressTableModel::setData (Wladimir J. van der Laan)
    37d30ec3cf
  158. better std::exception logging for block/undo files 7e08e29117
  159. qt: Remove unused method OptionsModel::getTransactionFee 2a7201570b
  160. Merge pull request #3489
    2a72015 qt: Remove unused method OptionsModel::getTransactionFee (Wladimir J. van der Laan)
    65515c0d05
  161. [Qt] massive options/settings rework (no core changes)
    - add new options for database cache and script verification threads
    - add label which displays options that are overridden by command-line
      parameters
    - proxy settings are not applied on-the-fly anymore and require a client
      restart (ApplyProxySettings() was removed and was not working very well
      anyway)
    - re-work options reset and require a client shutdown (as it is much
      easier to do it this way without having to mess with what can be changed
      on-the-fly and what needs a restart anyway)
    - options reset now writes default values for every single option
    - when changing an option which requires a client restart display a 10
      second warning message in statusLabel (via a QTimer)
    - when applying the changes via ok change that to a persistent message,
      which is displayed even after closing optionsdialog and re-open it, when
      no client restart was made
    - remove dialog boxes used when changing language or proxy settings
    - add setRestartRequired() and isRestartRequired() to OptionsModel and
      use the set function when updating options to signal OptionsDialog
      when a restart is needed
    - resize optionsdialog a little and add some min sizes for certain GUI
      elements
    - remove apply button from optionsdialog
    - save and restore optionsdialog window position
    - update nTransactionFee in QSettings with a set -paytxfee value when
      opening optionsdialog (I'm not sure about this yet, perhaps revert to
      not updating QSettings and just display current -paytxfee value in
      optionsdialog.)
    7e195e8459
  162. qt: Better status text for mined transactions
    Fixes ancient issue #614.
    04f58ffd9d
  163. build: Correctly put boost at end of LDADD
    This fixes linking issues when statically linking
    (thanks @imwuzhh).
    d696820b45
  164. Merge pull request #3449
    8b9adca Allow `-noserver` with bitcoind (Wladimir J. van der Laan)
    549e69a558
  165. qt: Update translations
    Update current translations, and add new languages:
    
    - es_MX: Spanish (Mexico)
    - pam: Kapampangan
    
    Also update translation process for autoconf-based build system.
    6d697e9fa4
  166. [Qt] update bitcoin-qt.pro and assets-attribution.md
    - remove unused and unmentioned file notsynced.png (we use an animation
      for this)
    - add missing coincontroldialog.ui to bitcoin-qt.pro
    - also unify formating in assets-attribution.md
    b960fcb86a
  167. Merge pull request #3491
    04f58ff qt: Better status text for mined transactions (Wladimir J. van der Laan)
    13e99e463d
  168. Add test for GetTime()
    Test for mingw/wine issue #3494, where the upper word of time(NULL)
    return value gets clobbered.
    eaafa23cbd
  169. Upgrade gitian win32 to boost-1.55.
    Fixes issue where all network activity just stops.
    56fce1fdbb
  170. Merge pull request #3498
    eaafa23 Add test for GetTime() (Wladimir J. van der Laan)
    16ae1c0da1
  171. Merge pull request #3432
    b960fcb [Qt] update bitcoin-qt.pro and assets-attribution.md (Philip Kaufmann)
    c07dd453e4
  172. gitian: Add -O2 for win32 build
    In the win32 gitian descriptor the C*FLAGS are being overridden on
    `configure`, which causes the built-in optimization flags to be removed.
    Add `-O2` manually (but not `-g` as we're not doing anything with the
    debug information).
    
    Improves performance of win32 gitian builds.
    
    As a bonus, fixes issue #3497.
    0d512a9ee7
  173. Merge pull request #3503
    0d512a9 gitian: Add -O2 for win32 build (Wladimir J. van der Laan)
    6b06e4fd0d
  174. Merge pull request #3501
    56fce1f Upgrade gitian win32 to boost-1.55. (Warren Togami)
    5c72e3df3c
  175. Merge pull request #3488
    2102ab9 ui: Fix GUI initialization order (Wladimir J. van der Laan)
    5b45bf400e
  176. [Qt] display native dir separators in select dadatir dialog
    - fixes display on Windows now \ instead of / before
    6a1bf00425
  177. Merge pull request #3504
    6a1bf00 [Qt] display native dir separators in select dadatir dialog (Philip Kaufmann)
    131fb42b1b
  178. Merge pull request #3347
    7e195e8 [Qt] massive options/settings rework (no core changes) (Philip Kaufmann)
    a036b796d1
  179. Add missing MacPorts dependencies to osx build docs f5e9d983c0
  180. Merge pull request #3506
    f5e9d98 Add missing MacPorts dependencies to osx build docs (Michael Ford)
    62e9d77496
  181. qt5: Ensure correct link order
    If optional libs don't appear in QT_LIBS, they need to be listed first for
    proper static linking.
    328bdb1cd6
  182. qt5: fix a build issue with osx and qtdbus
    See comment in notificator.cpp for details.
    c614bd718b
  183. qt5: split out qt config and add qt5 support
    Qt5 detection is a big ugly mess, but at least we can fence it off.
    c8ba8ef654
  184. qt5: Use the info gleaned from configure for plugin importing 60dc589477
  185. qt5: Use QT_SELECT for debian-based distros.
    At least Debian/Ubuntu use 'qtchooser' for switching between qt4/qt5 binaries.
    It is a wrapper for all qt tools, and calls the named tool of the default
    version unless overridden by the -qt= option or QT_SELECT environment variable.
    QT_SELECT is set by configure once the qt version has been chosen.
    
    Take for example, moc.
    
    $ which moc
        /usr/bin/moc
    
    $ ls -go /usr/bin/moc
        lrwxrwxrwx 1 9 Jul  3 21:33 /usr/bin/moc -> qtchooser
    
    $ qtchooser -print-env
        QT_SELECT="default"
        QTTOOLDIR="/usr/lib/x86_64-linux-gnu/qt4/bin"
        QTLIBDIR="/usr/lib/x86_64-linux-gnu"
    
    $ QT_SELECT=qt5 qtchooser -print-env
        QT_SELECT="qt5"
        QTTOOLDIR="/usr/lib/x86_64-linux-gnu/qt5/bin"
        QTLIBDIR="/usr/lib/x86_64-linux-gnu"
    
    $ moc -v
        Qt Meta Object Compiler version 63 (Qt 4.8.4)
    
    $ QT_SELECT=qt5 moc -v
        Qt Meta Object Compiler version 67 (Qt 5.0.1)
    
    This should be harmless elsewhere.
    47ffb50533
  186. qt5: tests: Make sure static plugin symbols are pulled in
    Since we're now properly linking against static plugins for qt binaries,
    we need to ensure that they're Imported properly.
    
    Without these Imports, the linker drops some of the unused linked libs, causing
    undefined symbols in QtCore.
    8b0f608815
  187. qt5: Force macports default include path to be searched last
    Allows outside includes to take precedence. In particular, this allows for
    a specified Qt to be used without clashing with macports' headers.
    2691cbc4b3
  188. qt5: fix --with-qt with no arguments 371f3f6ba5
  189. qt5: fix typo causing broken selection logic 42cc96737c
  190. Merge pull request #3346
    42cc967 qt5: fix typo causing broken selection logic (Cory Fields)
    371f3f6 qt5: fix --with-qt with no arguments (Cory Fields)
    2691cbc qt5: Force macports default include path to be searched last (Cory Fields)
    8b0f608 qt5: tests: Make sure static plugin symbols are pulled in (Cory Fields)
    47ffb50 qt5: Use QT_SELECT for debian-based distros. (Cory Fields)
    60dc589 qt5: Use the info gleaned from configure for plugin importing (Cory Fields)
    c8ba8ef qt5: split out qt config and add qt5 support (Cory Fields)
    c614bd7 qt5: fix a build issue with osx and qtdbus (Cory Fields)
    328bdb1 qt5: Ensure correct link order (Cory Fields)
    6a0e2376a1
  191. qt: Move initialization/shutdown to a thread
    Move AppInit2 and Shutdown to a thread.
    
    This allows a more responsive splash screen, prevents 'process does not respond'
    messages from the window system and will allow for showing a user friendly
    window while shutting down.
    202d853bbe
  192. qt: Show window while shutting down
    Makes it clear to the user that the application is still wrapping up
    and the computer should not be turned off until it is finished.
    55fe4de960
  193. qt: Remove global references in bitcoin.cpp
    Remove the need for global references `guiref` and
    `splashref` by making the BitcoinGUI and SplashScreen
    classes register for the UI interface signals themselves.
    35ecf854c0
  194. qt: Stop shutdown detection timer during shutdown
    Stop the shutdown timer from exiting the main loop
    when shutdown is already in progress.
    
    Fixes seeming hanging window after typing 'stop' in debug console.
    
    Also hide the debug console during shutdown as it is useless without
    a core to connect to.
    9a2305a1b3
  195. Merge pull request #3493
    9a2305a qt: Stop shutdown detection timer during shutdown (Wladimir J. van der Laan)
    35ecf85 qt: Remove global references in bitcoin.cpp (Wladimir J. van der Laan)
    55fe4de qt: Show window while shutting down (Wladimir J. van der Laan)
    202d853 qt: Move initialization/shutdown to a thread (Wladimir J. van der Laan)
    054be736d4
  196. build: pass correct defs and include path to moc
    To make sure the right slots are generated, MOC needs -DHAVE_CONFIG_H
    and correct include path to include bitcoin-config.h.
    ec41342e3d
  197. GUI for --disable-wallet compiles and -disablewallet mode
    There is not much in the GUI to be done without wallet,
    though it's possible to change options, watch the sync process,
    and use the debug console.
    
    So embed the debug console in the main window.
    b7f4b6d35d
  198. Merge pull request #3392
    b7f4b6d GUI for --disable-wallet compiles and -disablewallet mode (Wladimir J. van der Laan)
    ec41342 build: pass correct defs and include path to moc (Wladimir J. van der Laan)
    061aff4c46
  199. makefile.am: split long lines into one file per line
    This makes it easier to read diffs.
    Cosmetic change to build system only.
    5a407bd095
  200. GUI: Fix design in overview page 9b146cd3ca
  201. small headers ordering cleanup
    - keep headers in alphabetical order
    - fix Makefile.am (2 files in 1 line - leftover)
    - remove some spaces etc.
    c037531d69
  202. Merge pull request #3510
    c037531 small headers ordering cleanup (Philip Kaufmann)
    dc64c3c374
  203. [Qt] guard bitcoin-config.h and remove dublicated help message code 245a6ab1ae
  204. [Qt] don't regenerate autostart link on every client startup
    - allows users to add additional paramaters via the autostart link
    - related to #2197
    04aa828728
  205. Store orphan blocks in serialized form da0fecffa7
  206. [Qt] fix alphabetical ordering in Makefile.am
    - also change to 1 file per line for more stuff in Makefile.am
    d464edfb8c
  207. Merge pull request #3507
    9b146cd GUI: Fix design in overview page (Cozz Lovan)
    b68c618c6d
  208. Merge pull request #3511
    245a6ab [Qt] guard bitcoin-config.h and remove dublicated help message code (Philip Kaufmann)
    0a4fefe18f
  209. Merge pull request #3513
    d464edf [Qt] fix alphabetical ordering in Makefile.am (Philip Kaufmann)
    0e469b5167
  210. Tweak linearize.py to give more flexibility
    Add the ability to start at a non-zero height, and allow for appending to
    an existing file.
    7a29fb5940
  211. Merge pull request #3518 from Michagogo/linearize-start-value
    Tweak linearize.py to give more flexibility
    be2fb2d603
  212. build: fix MacOSX build after ec41342
    Fix regression introduced in ec41342.
    
    Also use a less ugly solution, by defining the value of
    `MOC_DEFS` in the configure script instead of `Makefile.include`.
    67d60f7031
  213. Merge pull request #3524
    67d60f7 build: fix MacOSX build after ec41342 (Wladimir J. van der Laan)
    a7973c9b6b
  214. src/leveldb/Makefile is ignored?
    remove the "-" in leveldb-* to include src/leveldb/Makefile
    15570cc9aa
  215. qt: use series of pngs for spinner
    Use a series of .png frames for the spinner instead of a .mng.
    `mng` is an obscure image format and is not built by default into Qt5.
    
    This appears to improve the crispness of the spinner as well.
    
    Does not noticably increase the size (still ~27k) and the code
    is not more complicated either.
    f10b2d70d0
  216. qt: Minor message updates
    Used sending/receiving addresses -> Sending/receiving addresses
    Previously requested payments -> Requested payments (idea from @cozz in #3521)
    66a8829a33
  217. Merge pull request #3374
    bd70562 [Qt] add messages when handling local payment request files (Philip Kaufmann)
    f126973fd0
  218. Merge pull request #3528
    66a8829 qt: Minor message updates (Wladimir J. van der Laan)
    c7930c859e
  219. qt: English translation update f087ce8891
  220. Merge pull request #3532
    f087ce8 qt: English translation update (Wladimir J. van der Laan)
    b1347d5565
  221. Merge pull request #3516 from sipa/serorphans-head
    Store orphan blocks in serialized form
    266921e70f
  222. Merge pull request #3525
    15570cc src/leveldb/Makefile is ignored? (harry)
    e4f041bdd1
  223. Merge pull request #3526
    f10b2d7 qt: use series of pngs for spinner (Wladimir J. van der Laan)
    dbafb99472
  224. qt: Update copyright year in about dialog to 2014 5bab55898d
  225. build: Update the other win32 deps
    - miniupnpc-1.8
    - openssl-1.0.1e
    - zlib-1.2.8
    - libpng-1.6.8
    - qrencode-3.4.3
    2f158dfc93
  226. build: upgrade Qt used by windows build to 5.2.0 1e3abb4e3d
  227. qt: Update remaining "The Bitcoin Core Developers" b26de9d951
  228. build: use Ubuntu 12.04 for linux gitian build 279af1a2af
  229. update copyright year to 2014 8c20bbbed9
  230. [Qt] add missing lock in walletmodel 57d8e3f88f
  231. [Qt] 2 minor translation changes 81bad8b386
  232. Merge pull request #3537
    8c20bbb update copyright year to 2014 (Philip Kaufmann)
    7fb5894b4c
  233. [Qt] small paymentserver header cleanup c704532294
  234. Merge pull request #3540
    57d8e3f [Qt] add missing lock in walletmodel (Cozz Lovan)
    b0e8c4b0b9
  235. Merge pull request #3541
    c704532 [Qt] small paymentserver header cleanup (Philip Kaufmann)
    6b5fbc9073
  236. Merge pull request #3538
    81bad8b [Qt] 2 minor translation changes (Philip Kaufmann)
    1aac1448de
  237. Merge pull request #3426
    16ec904 Don't create empty transactions when reading corrupted wallet (Wladimir J. van der Laan)
    f8b48ed297
  238. Update configure.ac
    Added ubuntu 13.10 and libboost1.54-all-dev incompatibility instruction to the existing no boost_sleep warning.
    720731d281
  239. Update build-unix.md
    Added incompatibility and instruction regarding Ubuntu 13.10 and libboost1.54-all-dev
    69843c8b4e
  240. doc: bump boost version in release-process
    This was forgotten in #3501.
    f4bb12eecc
  241. gitian: add explicit dependency build for linux
    Create a dependency file per architecture:
    
    - bitcoin-deps-linux32-gitian-r1.tar.gz
    - bitcoin-deps-linux64-gitian-r1.tar.gz
    04257151b1
  242. Merge pull request #3527 from laanwj/2014_01_gitian_win32_qt5
    build: update win32 deps
    8c31f037b1
  243. Merge pull request #3536
    0425715 gitian: add explicit dependency build for linux (Wladimir J. van der Laan)
    279af1a build: use Ubuntu 12.04 for linux gitian build (Wladimir J. van der Laan)
    4b4b578cb3
  244. Make gitian builds consistent across platforms
    Change Linux deps to use a zip archive rather than a gzipped tarball to
    match win32
    Rename Linux descriptor to gitian-linux.yml to match win32
    f4e72bf8d2
  245. Added automake to the macports depdency list as it was required to complete the autogen.sh step as it required aclocal (which isn't included in recent versions of xcode). 8d31e614e8
  246. Merge pull request #3546
    f4e72bf Make gitian builds consistent across platforms (Micha)
    417aad4a38
  247. Merge pull request #3547
    8d31e61 Added automake to the macports depdency list as it was required to complete the autogen.sh step as it required aclocal (which isn't included in recent versions of xcode). (Scott Willeke)
    8da2b3316c
  248. Merge pull request #3542
    69843c8 Update build-unix.md (Christopher Latham)
    720731d Update configure.ac (Christopher Latham)
    5753824171
  249. Merge pull request #3512
    04aa828 [Qt] don't regenerate autostart link on every client startup (Philip Kaufmann)
    08ede8ef5e
  250. Merge pull request #3490
    7e08e29 better std::exception logging for block/undo files (Philip Kaufmann)
    6c19ca1f92
  251. Merge src/leveldb changes: temporarily revert to writing .sst files. b9d384a45d
  252. wtogami commented at 1:46 PM on January 18, 2014: contributor

    ACK

  253. BitcoinPullTester commented at 2:14 PM on January 18, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b9d384a45dfe9f258a81aee7341b32dcd712a494 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  254. laanwj referenced this in commit fb766b640c on Jan 18, 2014
  255. laanwj merged this on Jan 18, 2014
  256. laanwj closed this on Jan 18, 2014

  257. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me