Add or amend tooltips to clarify what the 'message' is for, and add a note that it isn't sent over the network.
ui: Clarify help messages for 'message' fields #3571
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_01_ui_message_help changing 2 files +7 −4-
laanwj commented at 1:02 PM on January 22, 2014: member
-
in src/qt/forms/sendcoinsentry.ui:None in 72c09a2169 outdated
152 | @@ -153,6 +153,9 @@ 153 | </item> 154 | <item row="3" column="1"> 155 | <widget class="QLabel" name="messageTextLabel"> 156 | + <property name="toolTip"> 157 | + <string>A message that was attached to the Bitcoin URI which will be stored with the transaction for your reference. Note: This message is not sent over the network.</string>
Diapolo commented at 2:37 PM on January 22, 2014:Would it be more clear if you say:
Note: This message was not sent through the bitcoin network.
laanwj commented at 3:11 PM on January 22, 2014:This is still 'will be' as the payment has not been sent yet. But apart from that, yes, seems a bit better.
in src/qt/forms/receivecoinsdialog.ui:None in 72c09a2169 outdated
52 | @@ -53,7 +53,7 @@ 53 | <item row="6" column="2"> 54 | <widget class="QLineEdit" name="reqMessage"> 55 | <property name="toolTip"> 56 | - <string>The message to attach to payment request</string> 57 | + <string>An optional message to attach to the payment request, which will be displayed when the request is opened. Note: The message is not sent with the payment over the network.</string>
Diapolo commented at 2:38 PM on January 22, 2014:And here:
Note: This message will not be sent through the bitcoin network.laanwj commented at 7:55 AM on January 23, 2014: memberOk, updated the messages, also updated a few others to make it clear that the fields are optional.
in src/qt/forms/receivecoinsdialog.ui:None in 5514c7998a outdated
61 | </item> 62 | <item row="2" column="2"> 63 | <widget class="QLabel" name="label_5"> 64 | <property name="text"> 65 | - <string>Use this form to request payments. All fields are optional.</string> 66 | + <string>Use this form to request payments. All fields are OPTIONAL.</string>
Diapolo commented at 8:48 AM on January 23, 2014:I really dislike that uppercase usage, can't help...
laanwj commented at 8:51 AM on January 23, 2014:The alternative would be bold. Choose your poison wisely.
laanwj commented at 4:27 PM on January 23, 2014:Hah, or maybe we could make the text another color
Seriously, what would you propose to make it more clear? It seems a lot of people read over it.
Diapolo commented at 7:48 PM on January 23, 2014:I would make it bold and use ! at the end. Uppercase seems like bad UX design to me, but that could only be a personal taste. Perhaps even easier to use a new line and write:
Hint: All fields are optional!
laanwj commented at 10:38 AM on January 24, 2014:Alright, changed it to bold, indeed looks better than UPPERCASE. I don't like ! at the end except for errors.
BitcoinPullTester commented at 9:08 AM on January 23, 2014: noneAutomatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5514c7998a6ae6ba2ab614e130c93ddb7a216061 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
57feb1ba5aui: Clarify help messages for 'message' fields
Add or amend tooltips to clarify what the message is for and that it doesn't go over the network.
laanwj referenced this in commit d0a94f2c2f on Jan 24, 2014laanwj merged this on Jan 24, 2014laanwj closed this on Jan 24, 2014laanwj deleted the branch on Apr 9, 2014DrahtBot locked this on Sep 8, 2021Contributors
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC
More mirrored repositories can be found on mirror.b10c.me