unified and better log/error messages for CDBEnv/CDB #3572

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:db changing 1 files +22 −23

Diapolo commented at 1:45 PM on January 22, 2014: none

No description provided.
Diapolo commented at 1:57 PM on March 10, 2014: none

@laanwj Seems a recent Transifex update included something bad:

<pre> lrelease error: Parse error at /mnt/bitcoin/win32-build/src/qt/locale/bitcoin_ko_KR.ts:1183:22: Unexpected ''. RCC: Error in 'bitcoin.qrc': Cannot find file 'locale/bitcoin_ko_KR.qm' </pre>
sipa commented at 3:40 PM on March 10, 2014: member

ACK if pulltester is happy.
laanwj commented at 3:49 PM on March 10, 2014: member

@Diapolo whoa that's weird, so transifex is giving us an unparseable .ts file. I don't see anything strange at that line in bitcoin_ko_KR.ts.
laanwj commented at 4:07 PM on March 10, 2014: member

OK, pushed a fix for the translation file. There were some stray control characters in there (^H and ^) that lrelease could not cope with. This is really weird. I wonder if we should add a script to sanitize after tx pull.
Diapolo commented at 4:45 PM on March 11, 2014: none

Let's see if @BitcoinPullTester is happy now...
Diapolo commented at 8:30 AM on March 27, 2014: none

@sipa As pulltester is happy, do you mind merging this?
unified and better log/error messages for CDBEnv/CDB f7257cfbd9
BitcoinPullTester commented at 3:17 AM on April 2, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f7257cfbd9f676367b7d65bb38557bc7620c5cf8 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 8:17 AM on April 4, 2014: none

@laanwj Mind merging this?
laanwj commented at 10:20 AM on April 4, 2014: member

@Diapolo sure, but we're swamped with all kinds of pulls that update, improve or worsen the logging in subtle ways. That's giving quite a lot of review overhead without much apparent gain. This one seems noncontroversial though so it's fine with me...
laanwj commented at 10:23 AM on April 4, 2014: member

BTW If logging the function in which something happens is so important, it's be fairly easy to add that automatically to logging messages with a macro that uses __func__.
laanwj referenced this in commit b12dcb2c9e on Apr 4, 2014
laanwj merged this on Apr 4, 2014
laanwj closed this on Apr 4, 2014
Diapolo deleted the branch on Apr 5, 2014
DrahtBot locked this on Sep 8, 2021

Contributors