[Qt] move helpmessage from debug window to main menu #3573

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:helpmessage changing 5 files +16 −37

Diapolo commented at 1:49 PM on January 22, 2014: none
- the option to show our help message dialog resides now in main menu under help

[Qt] move helpmessage from debug window to main menu

- the option to show our help message dialog resides now in main menu
  under help

f0219813d5

in src/qt/bitcoingui.cpp:None in 13d0208af3 outdated

 307 | @@ -308,11 +308,15 @@ void BitcoinGUI::createActions(bool fIsTestnet)
 308 |      openAction = new QAction(QApplication::style()->standardIcon(QStyle::SP_FileIcon), tr("Open &URI..."), this);
 309 |      openAction->setStatusTip(tr("Open a bitcoin: URI or payment request"));
 310 |  
 311 | +    showHelpMessageAction = new QAction(QApplication::style()->standardIcon(QStyle::SP_MessageBoxInformation), tr("Show &command-line options"), this);

laanwj commented at 2:25 PM on January 22, 2014:

Nit: just "Command-line options" instead of "Show command-line options"? IMO, the word "Show" doesn't add anything here.

Diapolo commented at 2:29 PM on January 22, 2014:

Sure and done!

laanwj commented at 2:32 PM on January 22, 2014: member

ACK
BitcoinPullTester commented at 3:13 PM on January 22, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f0219813d58c0708b48992dd1313d594aa773ac0 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 3c3cd878b9 on Jan 22, 2014
laanwj merged this on Jan 22, 2014
laanwj closed this on Jan 22, 2014
Diapolo deleted the branch on Jan 30, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester