Unit tests would fail if compiled with -DDEBUG_LOCKORDER (AssertLockHeld() would fail; AssertLockHeld() relies on the DEBUG_LOCKORDER code to keep track of locks held).
Fixed by LOCK'ing the wallet mutex in the unit tests that manipulate the wallet.
This only changes the unit tests, so I plan on pulling as soon as pull-tester is happy.
Rpctests.cpp shouldn't depend on the wallet, otherwise it won't compile with --disable-wallet anymore (if it is really necessary you could put an #ifdef ENABLE_WALLET around the code in question, or even better, move that code to rpc_wallet_tests.cpp which exists for that purpose)
Unit tests would fail if compiled with -DDEBUG_LOCKORDER (AssertLockHeld()
would fail; AssertLockHeld() relies on the DEBUG_LOCKORDER code to keep
track of locks held).
Fixed by LOCK'ing the wallet mutex in the unit tests that manipulate the
wallet.
Rebased and changed to work when configured --disable-wallet (lock wallet moved from CallRPC to wallet_tests).
ACK
ACK
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fd67424c829b9bb0ed7f4a53040524c560262810 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.