[Qt] harmonize strings used when exporting in addressbookpage #3579

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:addressbookpage changing 1 files +6 −6

Diapolo commented at 8:38 PM on January 23, 2014: none

No more message() for now, but uses the same strings as export wallet and export transactions.
wtogami commented at 9:00 PM on January 23, 2014: contributor

You are sneaking in unrelated cleanups again. =)
laanwj commented at 9:10 PM on January 23, 2014: member

Moving the this->model=model below the null check is wrong. This makes the object retain a stale pointer after asking it to forget the model.
[Qt] harmonize strings used when exporting in addressbookpage f3005c82b1
in src/qt/addressbookpage.cpp:None in 028dbdd53c outdated
```
 287 | +    if(!writer.write()) {
 288 | +        QMessageBox::critical(this, tr("Exporting Failed"),
 289 | +            tr("There was an error trying to save the address list to %1.").arg(filename));
 290 | +    }
 291 | +    else {
 292 | +        QMessageBox::information(this, tr("Exporting Successful"),
```
laanwj commented at 10:18 AM on January 24, 2014:

Why pop up a message when it is successful? In my experience in UI no news = good news. Most programs don't tell you when saving a file was successful, for example. For some really critical things such as backups there may be an argument to do this, and to show some statistics about the saved data for cross-checking, but this is simply a table export...

Diapolo commented at 7:39 AM on January 27, 2014:

Convinced...
BitcoinPullTester commented at 8:14 AM on January 27, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f3005c82b15a73358f53420aa798b5db9f9b1f7a for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 86fa1c9cf2 on Jan 27, 2014
laanwj merged this on Jan 27, 2014
laanwj closed this on Jan 27, 2014
Diapolo deleted the branch on Jan 27, 2014
sidhujag referenced this in commit 8b5ffe4a4e on Jul 14, 2020
DrahtBot locked this on Sep 8, 2021

Contributors