refactor: use const references in BanMan loop iterations #35801

pull Rajkaran-122 wants to merge 1 commits into bitcoin:master from Rajkaran-122:refactor-banman-const-ref changing 1 files +6 −6

Rajkaran-122 commented at 8:45 AM on July 25, 2026: none

This PR optimizes the iteration over m_banned in src/banman.cpp by using const references (const CSubNet& and const CBanEntry&) instead of copying the objects by value on every loop iteration.

This improves both performance and code quality by preventing unnecessary object copies during banlist evaluations (IsBanned, SweepBanned).
refactor: use const references in BanMan loop iterations f5b3183236
DrahtBot added the label Refactoring on Jul 25, 2026
DrahtBot commented at 8:45 AM on July 25, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35801.



Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
Rajkaran-122 force-pushed on Jul 25, 2026
Rajkaran-122 force-pushed on Jul 25, 2026
sedited commented at 10:19 AM on July 25, 2026: contributor

This change doesn't seem worth the review required to get this merged. Closing again.
sedited closed this on Jul 25, 2026

Contributors

Labels