This PR modernizes the map iterations in src/banman.cpp by utilizing C++17 structured bindings.
Replacing manual it.first/it.second access with const auto& [sub_net, ban_entry] = ... makes the code significantly more readable and expressive.
refactor: use structured bindings in BanMan iterations #35806
pull Rajkaran-122 wants to merge 1 commits into bitcoin:master from Rajkaran-122:refactor-banman-structured-bindings changing 1 files +4 −8-
Rajkaran-122 commented at 8:47 AM on July 25, 2026: none
-
refactor: use structured bindings in BanMan iterations afafcfe6a3
- DrahtBot added the label Refactoring on Jul 25, 2026
-
DrahtBot commented at 8:48 AM on July 25, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35806.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- Rajkaran-122 force-pushed on Jul 25, 2026
- Rajkaran-122 force-pushed on Jul 25, 2026
-
sedited commented at 10:19 AM on July 25, 2026: contributor
This change doesn't seem worth the review required to get this merged. Closing again.
- sedited closed this on Jul 25, 2026
Contributors
Labels