.
. #35815
pull dagimabebe wants to merge 4 commits into bitcoin:master from dagimabebe:master changing 2 files +62 −2-
dagimabebe commented at 7:52 PM on July 26, 2026: none
-
Update CMakeLists.txt fe033e23ae
-
Merge branch 'bitcoin:master' into master 00afc8eca9
-
266fad091e
test: Add P2SH sigop counting test for segwit blocks
Add tests verifying that P2SH sigop counting works correctly in segwit-active blocks. This addresses the TODO at the end of the test_witness_sigops subtest. The positive test creates a P2SH output with a P2PK redeem script (1 sigop), mines it, and spends it with a valid signature to confirm basic P2SH sigop counting works. The negative test creates a block containing 101 P2SH inputs with high-sigop redeem scripts (200 OP_CHECKSIG each, 200 sigops per input). At WITNESS_SCALE_FACTOR=4, each input contributes 800 sigop cost, totaling 80800 which exceeds MAX_SIGOP_COST (80000). The block is verified to be rejected with 'bad-blk-sigops'. Also updates the cleanup to reference tx_high_fund instead of the now-spent tx2 output.
-
d54560ae28
Merge pull request #1 from dagimabebe/test-p2sh-sigops-segwit
test: Add P2SH sigop counting test for segwit blocks
- DrahtBot added the label Tests on Jul 26, 2026
-
DrahtBot commented at 7:52 PM on July 26, 2026: contributor
LLM spam detection (✨ experimental): SPAM. The submission body contains only the default contributor template and provides no actual description of the proposed change, rationale, or test details—suggesting an empty/placeholder PR rather than a legitimate contribution.
♻️ Automatically wiping, closing, and locking for now based on heuristics. Generally, please focus on creating high-quality, original content that demonstrates a clear understanding of the project's requirements and goals.
- DrahtBot renamed this:
test: Add P2SH sigop counting test for segwit blocks
.
on Jul 26, 2026 - DrahtBot closed this on Jul 26, 2026
- DrahtBot removed the label Tests on Jul 26, 2026
- bitcoin locked this on Jul 26, 2026
-
DrahtBot commented at 7:52 PM on July 26, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35815.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Contributors