[Qt] minor receive tab improvements #3585

• draw border around upper form
• align clear button with form elements
• set stretch on the Requested payments table in vertical layout. This is to have better looking and more useful behavior, when resizing/maximizing the window
• show tooltips also for the labels itself (label,amount,message)
• show (no amount) instead of 0.00, similar to (no label) and (no message)
• add keyboard support for pressing return. When upper form focused and return pressed -> submit form (Request payment)
• rename "Requested payments" to "Requested payments history" @laanwj What do you think about removing the "Requested payments" table from the front page and put it in a popup instead, by clicking a button "Requested payments history". Currently the table looks very important, but its only a history, in case you want to look something up. Also when adding the real payment request to the form, we need more space anyway...

Before:

After:

Nice improvements.

I really like the history in the tab itself. IMO it is very important to the user experience. It's easy to accidentally click away the QR dialog. Now it's just a matter of double-clicking to bring back the most recent entry.

@laanwj yes, quick history access can be useful. It was just an idea with the popup...

I still think this is how the "Request payment" "Clear" buttons should be positioned. Just below you have the same thing "Show" "Remove".

As I've said before I want to keep the form consistent with the 'send' tab, which has action buttons on the right not left. It's possible to change the send tab as well, but don't make this inconsistent between tabs.

Edit: I do think I like it better with the buttons on the left, though, it's an improvement

Send tab would look like this. I like it.

Before:

After:

Yes, I like it too.

Edit: and we get the balance aligned to the right for free!

update:

• button positions in send tab
• button positions in receive tab
• add context menu to history, copy label,message,amount. I think a common use case is to create a request with the same label, so quick copy access is important IMO. I did not implement copy address/URI on purpose, because you dont see it, this might be too dangerous. If multiple rows selected, the first one is used.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/688a86694e9010241e7cbbfda6a12dfcc15e37b6 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

You need to update the tab chain as well for the sendcoins dialog. It still goes first to Add Recipient, then Send. Same for the receive tab, it first goes to Clear then Receive Payment.

Merged through #3598