log parameter interactions to debug.log #3588

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:param_interaction changing 1 files +17 −9

Diapolo commented at 10:27 AM on January 27, 2014: none

No description provided.

in src/init.cpp:None in 743ea2f501 outdated

 441 |      if (!GetBoolArg("-listen", true)) {
 442 |          // do not map ports or try to retrieve public IP when not listening (pointless)
 443 | -        SoftSetBoolArg("-upnp", false);
 444 | -        SoftSetBoolArg("-discover", false);
 445 | +        if (SoftSetBoolArg("-upnp", false))
 446 | +            LogPrintf("AppInit2 : parameter interaction: -listen unset -> setting -upnp=0\n");

laanwj commented at 10:53 AM on January 27, 2014:

I'd say "-listen=0 -> setting -upnp=0" here. "unset" (in the above messages) implies that the parameter is not set at all, while it checks here that it's set to 0.

in src/init.cpp:None in 743ea2f501 outdated

 457 |  
 458 |      if (GetBoolArg("-salvagewallet", false)) {
 459 |          // Rewrite just private keys: rescan to find transactions
 460 | -        SoftSetBoolArg("-rescan", true);
 461 | +        if (SoftSetBoolArg("-rescan", true))
 462 | +            LogPrintf("AppInit2 : parameter interaction: -salvagewallet set -> setting -rescan=1\n");

laanwj commented at 10:54 AM on January 27, 2014:

same here "-salvagewallet=1 -> setting -rescan=1"

laanwj commented at 10:55 AM on January 27, 2014: member

ACK apart from the nits, these kind of details can be useful when trying to find out why a certain parameter ended up at a certain value.
log parameter interactions to debug.log df966d1b24
Diapolo commented at 11:11 AM on January 27, 2014: none

Fixed nits, thanks for your feedback.
BitcoinPullTester commented at 11:56 AM on January 27, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/df966d1b24a5cde06625906c4f1b72f393d9d133 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 9b818ed8bf on Jan 30, 2014
laanwj merged this on Jan 30, 2014
laanwj closed this on Jan 30, 2014
Diapolo deleted the branch on Jan 30, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester