Use standard BIP 22 rejection reasons where applicable #3592

pull luke-jr wants to merge 2 commits into bitcoin:master from luke-jr:bip22_rejreason changing 2 files +47 −45

luke-jr commented at 8:21 AM on January 28, 2014: member

No description provided.
Use standard BIP 22 rejection reasons where applicable 14e7ffcc64
Support for error messages and a few more rejection reasons c117d9e93a
in src/main.cpp:None in 0da64dfdb2 outdated
```
 604 | @@ -605,14 +605,14 @@ bool CheckTransaction(const CTransaction& tx, CValidationState &state)
 605 |      // Basic checks that don't depend on any context
 606 |      if (tx.vin.empty())
 607 |          return state.DoS(10, error("CheckTransaction() : vin empty"),
 608 | -                         REJECT_INVALID, "vin empty");
 609 | +                         REJECT_INVALID, "bad-txns-vin empty");
```
laanwj commented at 9:58 AM on January 28, 2014:

This looks like a kind of chimera of the old string and the "standard rejection reason" from BIP22. How does this work in practice, is only the initial part matched to the 'Reason' table in https://github.com/bitcoin/bips/blob/master/bip-0022.mediawiki? Should we be consistent and use either the minus-delimited-style or the space delimited style of message?

luke-jr commented at 4:00 PM on January 28, 2014:

In practice, it's really only seen/used by humans right now. I figured this was a good compromise of consistency between different software, without sacrificing the level of detail bitcoind is able to provide. Replacing the space with a dash/minus sounds like a good improvement to me.
BitcoinPullTester commented at 6:14 PM on January 29, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c117d9e93a712c3f1e2001bdb6e20e7a1c5e339b for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 7:45 AM on January 30, 2014: member

ACK
jgarzik commented at 2:53 PM on January 30, 2014: contributor

ACK
sipa commented at 3:37 PM on January 30, 2014: member

ACK
laanwj referenced this in commit 19007cf552 on Jan 30, 2014
laanwj merged this on Jan 30, 2014
laanwj closed this on Jan 30, 2014
rebroad commented at 5:57 AM on March 27, 2014: contributor

Can someone post a reference to the BIP 22 document on here please? (and BIP30?)
christophebiocca commented at 7:38 PM on March 28, 2014: none

BIP0022 BIP0030
luke-jr deleted the branch on Jan 1, 2015
DrahtBot locked this on Sep 8, 2021

Contributors