refactor: remove unused GetCScripts function #35922

pull vicjuma wants to merge 1 commits into bitcoin:master from vicjuma:script-remove-unused-getcscripts changing 2 files +0 −11
  1. vicjuma commented at 10:06 PM on August 6, 2026: none

    The function FillableSigningProvider::GetCScripts() const is not being used anywhere in the codebase

  2. script: remove unused GetCScripts
    the function is not used in the codebase
    77f976cbc4
  3. DrahtBot added the label Consensus on Aug 6, 2026
  4. DrahtBot commented at 10:06 PM on August 6, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35922.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #35733 (sign: Remove FillableSigningProvider by achow101)
    • #34520 (refactor: Add [[nodiscard]] to functions returning bool+mutable ref by maflcko)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. vicjuma renamed this:
    script: remove unused GetCScripts function
    refactor: remove unused GetCScripts function
    on Aug 6, 2026
  6. maflcko removed the label Consensus on Aug 7, 2026
  7. DrahtBot added the label Refactoring on Aug 7, 2026
  8. DrahtBot closed this on Aug 7, 2026

  9. DrahtBot reopened this on Aug 7, 2026

  10. instagibbs commented at 1:48 PM on August 9, 2026: member

    conflicts with #35733 which is nuking the whole thing. Perhaps just review that one?

  11. vicjuma commented at 1:55 PM on August 9, 2026: none

    conflicts with #35733 which is nuking the whole thing. Perhaps just review that one?

    That's reasonable. Will do

  12. sedited commented at 2:17 PM on August 9, 2026: contributor

    Closing as duplicate of #35733

  13. sedited closed this on Aug 9, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-14 18:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me