add header, which includes default values for certain parameters #3595

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:defaultvalues changing 7 files +48 −17

Diapolo commented at 10:28 AM on January 28, 2014: none
- most of these are used in core and GUI, so it made sense to bring this together, as it removes the need to keep 2 places in sync
- also adds a new check to now set a -dbcache greater than what is allowed for x86 and x64 platforms

add header, which includes default values for certain parameters

- most of these are used in core and GUI, so it made sense to bring this
  together, as it removes the need to keep 2 places in sync
- also adds a new check to now set a -dbcache greater than what is
  allowed for x86 and x64 platforms

4c8212802c

laanwj commented at 10:52 AM on January 28, 2014: member

This is not the right direction. You're combining network, wallet, blockchain database, verification constants all into one header file, where we plan to modularize stuff.

I'm all for eliminating magic numbers, but please put the constants in their own localized header files (that already exist, no need to make a new one).
BitcoinPullTester commented at 11:02 AM on January 28, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4c8212802c5900158d03c749667dc6adef48a618 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 2:03 PM on January 29, 2014: none

@laanwj Well, I for sure can put the constants in the corresponding header files, but then optionsmodel.cpp for example will include all these to access the constants, right?
laanwj commented at 8:40 AM on January 30, 2014: member

Of course
laanwj commented at 2:33 PM on February 9, 2014: member

Closing this for now as I don't like the idea of centralization into a single header. If you want to clean up magic values in some other way, please open a new pull.
laanwj closed this on Feb 9, 2014
Diapolo deleted the branch on Feb 17, 2014
sidhujag referenced this in commit 435b89214f on Jul 14, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester