doc: adding display server protocol after X11 #35973

Not specifying what X11 is before this commit. Added: "display server protocol after X11". Not so clear what X11 means without this.

<!-- *** Please remove the following help text before submitting: *** Pull requests may be closed immediately if they: - do not have a rationale and clear improvement - do not adhere to doc/AI_POLICY.md GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

<!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

<!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35973.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

This isn't wrong, but I think the whole ("and uses the xcb QPA (Qt Platform Abstraction) platform plugin to run on X11") could be dropped. bitcoin-qt runs fine with the wayland plugin as well.

Another option (Looks cooler from my point of view, also more informative. After X11 display server protocol.): bitcoin-qt can run on wayland communication protocol.

Should i add that?

Also, shouldn't X11 be X11 instead?. Should i add this too?

@xHope-tech Thank you for your contribution! However, I believe the documentation is fine as is. X11 is ubiquitous in the Linux world. Moreover, the following sentence refers to "runtime library dependencies", which implies that X11 also refers to the protocol implementation rather than the protocol itself. Therefore, it's okay to keep simply "X11".

Also, the branch should not contain any merge commits. @diegoviola:

This isn't wrong, but I think the whole ("and uses the xcb QPA (Qt Platform Abstraction) platform plugin to run on X11") could be dropped. bitcoin-qt runs fine with the wayland plugin as well.

That holds for builds against distro Qt packages, but doc/INSTALL_linux.md is shipped as INSTALL.md in the Linux release packages, and the wayland plugin is not compiled into those binaries, only xcb is available. So the current sentence is accurate for its audience.

That holds for builds against distro Qt packages, but doc/INSTALL_linux.md is shipped as INSTALL.md in the Linux release packages, and the wayland plugin is not compiled into those binaries, only xcb is available. So the current sentence is accurate for its audience.

Makes sense, thanks for clarifying. My comment was in relation to depends changing in the future but until that happens I'm happy to keep things as they are.

closing for now, per previous discussion