miniscript: make typing rule match BIP-379 exactly #36028

pull sipa wants to merge 1 commits into bitcoin:master from sipa:202608_miniscript_bip_rules changing 1 files +4 −6
  1. sipa commented at 8:42 PM on August 19, 2026: member

    The BIP-379 text specifies rule for reasoning about correctness and malleability through a number of type properties. These rules are implemented in Bitcoin Core's miniscript implementation.

    There are multiple equivalent ways of writing these. For example, the BIP text says that an or_b fragment always has the "e" (uniquely dissatisfiable) property. The Bitcoin Core implementation however only assigns it the "e" property when both child expressions have "e" as well. This is an irrelevant distinction, because the "e" property is only used for reasoning about malleability, and an or_b whose children do not have "e" is always malleable. Thus, for all cases where it matters, "always e" and "e when children have e" are equivalent.

    In the context of https://github.com/bitcoin/bips/pull/2240, which adds test vectors to BIP-379, it is helpful however to make the implementation match the specification exactly, even for these cases where it does not matter.

    Draft until these is some agreement on this approach in https://github.com/bitcoin/bips/pull/2240.

  2. miniscript: make typing rule match BIP-379 exactly 2631ece7b5
  3. DrahtBot added the label Descriptors on Aug 19, 2026
  4. DrahtBot commented at 8:42 PM on August 19, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36028.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-21 04:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me