Make ConnectBlock static, in order to expose the side effects.
Relevant:
Make ConnectBlock static, in order to expose the side effects. #36158
pull optout21 wants to merge 10 commits into bitcoin:master from optout21:connectblock-static changing 2 files +90 −39-
optout21 commented at 9:31 AM on September 3, 2026: contributor
-
Pass last_script_check_reason explicitly 70c90638db
-
Pass BlockManager explicitly d07a5d2e30
-
Introduce a struct for output parameters 9546624049
-
Handle incrementing num_blocks_total 8c56835ad4
-
Include time measurements in update result da0e23df46
-
Make ConnectBlockChecks const 6387825fa4
-
Pass ValidationCache explicitly (non-const) d52ea91f9a
-
Pass CheckQueue explicitly (non-const) 18b0054e6f
-
Pass ChainstateManager explicitly 79d78095cf
-
Pass role explicitly, make internal method static. 1127993a4d
-
DrahtBot commented at 9:31 AM on September 3, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36158.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
optout21 commented at 9:32 AM on September 3, 2026: contributor
Opened by mistake, closing
- optout21 closed this on Sep 3, 2026
