[Qt] remove broken OptionsModel::Upgrade() #3638

When starting bitcoin-qt without a qt-settings file, strOverriddenByCommandLine contains some false values, because OptionsModel::Upgrade() calls OptionsModel::Init() a second time and SoftSetArgs have been set before with default values.

Also to me it looks like OptionsModel::Init() assumes that AppInit2 is called after, but OptionsModel::Upgrade() is called after AppInit2. This would mean that some options set in OptionsModel::Upgrade() are not even applied. For example setting the proxy options through Upgrade() is broken, I assume (havent tested).

So my suggestion is to remove OptionsModel::Upgrade() completely.

Good idea, removing this has been on my mind for a while but I didn't get around to it. This only leads to surprises for people restoring old wallets with still settings in them.

You could also remove the *Setting methods on wallet/walletdb after this.

Added a second commit, removing the *Setting methods.

Only code removal. These are the best kinds of pull. ACK

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/cdb6c169355488d4e64a2435d916cb67a9c01ebe for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

I welcome the removal of that damn OptionsModel::Upgrade() function. I stumbled upon false values for overridden by command-line also, but didn't have time to debug it further... thanks for catching this.