common: Skip environment locale check on illumos #36399

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:261001-illumos-locale changing 1 files +4 −1

hebasto commented at 3:23 PM on October 1, 2026: member
On illumos-based distributions whose GCC is built with the --enable-clocale=dragonfly option (e.g. OmniOS, OpenIndiana), the std::ctype<char>::~ctype() destructor passes an uninitialized value to freelocale().

Constructing and destroying std::locale("") in SetupEnvironment() therefore intermittently crashes, e.g. with "libc thread failure: lfree() called with a misaligned pointer".

Upstream reports:
Closes https://github.com/hebasto/bitcoin-core-nightly/issues/315.

common: Skip environment locale check on illumos

On illumos-based distributions whose GCC is built with the
`--enable-clocale=dragonfly` option (e.g. OmniOS, OpenIndiana), the
`std::ctype<char>::~ctype()` destructor passes an uninitialized value
to `freelocale()`.

Constructing and destroying `std::locale("")` in `SetupEnvironment()`
therefore intermittently crashes, e.g. with "libc thread failure:
lfree() called with a misaligned pointer".

Upstream reports:
- https://github.com/illumos/gcc/pull/56#issuecomment-5933176361
- https://github.com/omniosorg/omnios-build/issues/4253
- https://www.illumos.org/issues/18481

ae15693011

DrahtBot commented at 3:24 PM on October 1, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36399.



Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
maflcko commented at 3:54 PM on October 1, 2026: member

Why is all of this code needed (https://github.com/bitcoin/bitcoin/pull/4174#issue-33259538) in the first place? At this point it may be better to delete it (possibly move it to the GUI, if it is needed there)
maflcko commented at 4:05 PM on October 1, 2026: member

to clarify: boost fs has long been removed (https://github.com/bitcoin/bitcoin/issues/4147#issuecomment-42491986)

Contributors

hebasto

DrahtBot

maflcko

common: Skip environment locale check on illumos #36399

Code Coverage & Benchmarks

Reviews