Log warnings when bootstrap files are specified but cannot be opened #3643

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_02_bootstrap_errors changing 1 files +5 −1

laanwj commented at 10:36 AM on February 8, 2014: member
- Log a warning when bootstrap files are specified using -loadblock but cannot be opened.
- Log a warning when bootstrap.dat exists in the home directory but cannot be opened.
Makes it easier to debug problems where bitcoind somehow ignores the bootstrap.

Log warnings when bootstrap files are specified but cannot be opened

- Log a warning when bootstrap files are specified using `-loadblock`
but cannot be opened.
- Log a warning when bootstrap.dat exists in the home directory
but cannot be opened.

d54e819f65

in src/init.cpp:None in 9aa3164557 outdated
```
 347 | @@ -346,6 +348,8 @@ void ThreadImport(std::vector<boost::filesystem::path> vImportFiles)
 348 |              CImportingNow imp;
 349 |              LogPrintf("Importing %s...\n", path.string());
 350 |              LoadExternalBlockFile(file);
 351 | +        } else {
 352 | +            LogPrintf("Warning: Could not open bootstrap file %s\n", path.string());
```
sipa commented at 3:11 PM on February 8, 2014:

Perhaps confusing to call this bootstrap file?

laanwj commented at 6:07 PM on February 8, 2014:

Any better suggestion?

sipa commented at 6:15 PM on February 8, 2014:

"Could not open blocks file %s\n" ?

It's technically the same format as bootstrap.dat, but as it can be used to import arbitrary blocks, just calling it bootstrap too is probably a bit confusing.

laanwj commented at 6:31 PM on February 8, 2014:

Ok, will change it to that
BitcoinPullTester commented at 8:41 AM on February 9, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d54e819f65c193aaa018df6612257e84b6565c84 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 129429dd8f on Feb 17, 2014
laanwj merged this on Feb 17, 2014
laanwj closed this on Feb 17, 2014
laanwj deleted the branch on Apr 9, 2014
sidhujag referenced this in commit 5f7bce12bb on Aug 5, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

laanwj

sipa

BitcoinPullTester