[Qt] show fee warnings in optionsdialog #3647

1. 
   cozz commented at 1:56 AM on February 9, 2014: contributor

   (pull request title has also been edited)

   • set default fee to CTransaction::nMinTxFee instead of zero, for both bitcoin-qt and bitcoind. For bitcoin-qt only new installations are affected while for bitcoind, everbody who has not set -paytxfee is affected
   • add default value to --help output for -paytxfee
   • qt-optionsdialog: change fee description
   • qt-optionsdialog: add fee warnings
   • qt-optionsdialog: minor design improvements: added borders and aligned the database and verification threads controls

   Before:

   After:

   Warning if fee >= 5 * minFee. Useful for people who still have the old 50000 satoshis value. Also useful for people confusing BTC and mBTC...

   Warning if fee = nonsense value. 0 < fee < minFee

   Warning if fee = zero

2. 
   laanwj commented at 12:02 PM on February 9, 2014: member

   Looks good.

   I think it would be a good idea to split the GUI changes and the default change. The second is going to be a much harder sell. Personally I have the fee at 0 and I never have problems with transactions not getting mined.

   Also: Seems to me that with floating fees (#3335 is preparation for it) and automatic fee estimation this setting isn't needed anymore? (or at least it will change)

3. 
   cozz commented at 1:10 PM on February 9, 2014: contributor

   Ok, I have reverted the default fee to zero. So only Qt changes now. I also edited the pull request title.

   Another idea would be to let the user choose the fee on first run for bitcoin-qt. This is a mockup screen. What do you think?

4. 
   laanwj commented at 1:57 PM on February 9, 2014: member

   This makes the intro dialog very complicated. The way to do this would be to make it a multi-step wizard. But let's leave it at this for now. I hope the manual fee setting will soon not be needed anymore.

5. 
   laanwj commented at 2:06 PM on February 9, 2014: member

   ACK

6. 
   cozz commented at 2:07 PM on February 9, 2014: contributor

   Yes, an installation wizard is probably the way to go here. Some project for the future then :)

7. 
   Diapolo commented at 3:22 PM on February 10, 2014: none

   I don't like the GUI changes, it looks like our other options in main are a sub-option of the fee setting now. I would put the fee stuff into an own border and let the other options stay untouched.

   Your idea in general is good, also take a look at the Todo in optionsmodel.cpp perhaps this patch fully covers one of them and you can remove it.

8. 
   luke-jr commented at 4:57 AM on February 22, 2014: member

   Pushed this rebased as my cozz_feewarnings branch. It was a pain to do. :(

9. 
   cozz commented at 4:25 PM on February 22, 2014: contributor

   update:

   • updated to @luke-jr rebased version, thanks a lot! ( for going through the pain:) )
   • removed border around controls in Main-tab. Otherwise it looks inconsistent between Main and the other tabs (Network,...).
10. [Qt] show fee warnings in optionsdialog d8136022c2
11. laanwj added this to the milestone 0.10.0 on Apr 23, 2014
12. laanwj added the label GUI on May 9, 2014
13. laanwj added the label TX fees on May 9, 2014
14. 
    Diapolo commented at 1:06 PM on May 10, 2014: none

    I remember having a Todo in optionsmodel related to invalid fees, can you remove that, as this pull seems to take care of this.

15. 
    cozz commented at 1:10 PM on May 10, 2014: contributor

    @Diapolo Sure. I will remove it with the next update/rebase.

16. 
    BitcoinPullTester commented at 4:17 PM on June 23, 2014: none

    Automatic sanity-testing: FAILED MERGE, see http://jenkins.bluematt.me/pull-tester/p3647_d8136022c23aa6fe38a672109ee4eac83ee707de/ for test log.

    This pull does not merge cleanly onto current master This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

17. 
    wtogami commented at 2:18 AM on July 3, 2014: contributor

    @cozz need rebase

18. 
    cozz commented at 10:01 AM on July 3, 2014: contributor

    Closing this for now.

    I do not want to maintain/rebase this as long as there might be significant changes to the fee coming. Because they might make this pull request useless. So lets wait and see what happens regarding smart/floating fees.

    If this pull request is still useful, when we move towards the 0.10 release, I will reopen.

19. cozz closed this on Jul 3, 2014

    ---

20. 
    laanwj commented at 10:09 AM on July 3, 2014: member

    @cozz Agreed - that was also the reason for holding off merging this in the first place.

21. DrahtBot locked this on Sep 8, 2021

Milestone
0.10.0