minor style cleanups #3650

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:misc-main changing 3 files +11 −11

Diapolo commented at 3:31 PM on February 10, 2014: none

No description provided.
Diapolo referenced this in commit 76a77059f3 on Feb 21, 2014
in src/main.cpp:None in 08062663d6 outdated
```
3152 | -                         LogPrintf("ProcessGetData(): ignoring request for old block that isn't in the main chain\n");
3153 | -                       } else {
3154 | -                         send = true;
3155 | -                       }
3156 | +                        if (!chainActive.Contains(mi->second))
3157 | +                        {
```
cozz commented at 3:54 PM on February 21, 2014:

As you already go through style cleanups here, I was thinking about removing the excessive use of "{" "}" there around one-liner if-else-statements.

luke-jr commented at 3:57 PM on February 21, 2014:

+1

Diapolo commented at 3:58 PM on February 21, 2014:

I'd favor this, but I guess @laanwj will kill me then ;).
laanwj commented at 4:19 PM on February 21, 2014:

I've always found that { } are a good thing as they explicitly mark the beginning and end of a scope, which is good for maintainability. I've had to debug problems caused by people adding code like this many times:

if (!something) send = true; return; /// Oops
minor style cleanups 2b45345aac
BitcoinPullTester commented at 4:50 PM on March 11, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2b45345aaca9d0091972f983ac6e5c0b09d14777 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit acfe60677c on Mar 15, 2014
laanwj merged this on Mar 15, 2014
laanwj closed this on Mar 15, 2014
Diapolo deleted the branch on Mar 21, 2014
sidhujag referenced this in commit 4780bae57b on Aug 11, 2020
DrahtBot locked this on Sep 8, 2021

Contributors