A second btck_chainstate_manager_import_blocks call on the same chainstate manager, while one is in progress, aborts the process, and the kernel header does not say so. I document it. The abort is the assert in ImportingNow in node/blockstorage.cpp, which I keep.
kernel: document the import_blocks abort #36632
pull fametrano wants to merge 1 commits into bitcoin:master from fametrano:kernel-doc-process-block-dos changing 1 files +4 −0-
fametrano commented at 9:59 PM on October 23, 2026: contributor
- DrahtBot added the label Validation on Oct 23, 2026
-
DrahtBot commented at 9:59 PM on October 23, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36632
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36632.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36632#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- fametrano renamed this:
kernel: document that process_block stores unrequested blocks
kernel: document process_block storage and two aborting preconditions
on Oct 24, 2026 -
sedited commented at 10:21 AM on October 26, 2026: contributor
The first commit seems already documented to me. The second one's importblocks behaviour seems ok to add.
-
2077d1571e
kernel: document the import_blocks abort
A second btck_chainstate_manager_import_blocks call on the same chainstate manager, while one is in progress, aborts the process. The header does not say so. I add it to the header. I keep the assert in ImportingNow.
- fametrano force-pushed on Nov 1, 2026
- fametrano renamed this:
kernel: document process_block storage and two aborting preconditions
kernel: document the import_blocks abort
on Nov 1, 2026 -
fametrano commented at 6:36 PM on November 1, 2026: contributor
Dropped the first commit and the
spent_outputs_lennote. The PR now only documents theimport_blocksabort you said is ok to add. - sedited approved
-
sedited commented at 3:08 PM on November 4, 2026: contributor
ACK 2077d1571ee98f8b2fba611e8bdfc73797b8bd3f
- sedited merged this on Nov 4, 2026
- sedited closed this on Nov 4, 2026
Labels