mempool: clamp future mempool.dat entry times #36640

pull fametrano wants to merge 1 commits into bitcoin:master from fametrano:mempool-dat-clamp-time changing 2 files +18 −0
  1. fametrano commented at 6:01 AM on October 24, 2026: none

    A mempool.dat entry with a time in the future is loaded as it is, so its transaction never expires, whatever -mempoolexpiry says.

    I use the current time for such an entry. Earlier times are unchanged. Open PR #36540 removes time-based expiry, which would make this change moot. I tested this with a functional test that restarts a node with its clock behind a saved entry time. It fails without the change and passes with it.

    This is one of several PRs from a large audit of Bitcoin Core that I did with the help of LLM tools. The audit produced its evidence all at once, which is why the PRs arrive together. I understand each change fully and will answer review questions myself.

  2. mempool: clamp future mempool.dat entry times
    A mempool.dat entry with a time in the future is loaded as it is, so its
    transaction never expires, whatever -mempoolexpiry says.
    
    I use the current time for such an entry. Earlier times are unchanged.
    Open PR #36540 removes time-based expiry, which would make this change
    moot. I tested this with a functional test that restarts a node with its
    clock behind a saved entry time. It fails without the change and passes
    with it.
    c07124e5b5
  3. DrahtBot added the label Mempool on Oct 24, 2026
  4. DrahtBot commented at 6:01 AM on October 24, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. sedited commented at 8:50 AM on October 26, 2026: contributor

    This file is trusted anyway, so I don't think this needs any changing. Closing.

  6. sedited closed this on Oct 26, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-30 15:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me