depends: fetch qrencode from GitHub under a new file name #36650

pull fametrano wants to merge 1 commits into bitcoin:master from fametrano:depends-qrencode-github changing 1 files +4 −3
  1. fametrano commented at 12:54 PM on October 24, 2026: none

    https://fukuchi.org/works/qrencode/qrencode-4.1.1.tar.gz returns 404, so depends takes qrencode from the bitcoincore.org fallback. #33494 moved the download to the GitHub tag archive but kept the file name. The archive has a different hash. #33577 reverted it because the new hash under the old name broke the release branches. In #33577 theuni proposed to change the file name too, and achow101 agreed to do that in a follow-up.

    I download v4.1.1.tar.gz from https://github.com/fukuchi/libqrencode/archive/refs/tags/, with the hash from #33494, and store it as qrencode-4.1.1-v2.tar.gz. The old file name keeps its old hash on the fallback and in the CI caches. So the release branches are not affected. I left the doc/dependencies.md link, because the project page it points to still loads.

    The GitHub file matches 5385bc1b8c2f20f3b91d258bf8ccc8cf62023935df2d2676b5b67049f31a049c. With FALLBACK_DOWNLOAD_PATH=http://127.0.0.1:9, make -C depends qrencode builds qrencode on this branch and fails on master. The fallback does not have qrencode-4.1.1-v2.tar.gz yet. In #33577 the fallback picked up the new tarball from master by itself, so I expect it to add this file after a merge. I did not run a Guix build.

    This is one of several PRs from a large audit of Bitcoin Core that I did with the help of LLM tools. The audit produced its evidence all at once, which is why the PRs arrive together. I understand each change fully and will answer review questions myself.

  2. depends: fetch qrencode from GitHub under a new file name
    The qrencode tarball is no longer on fukuchi.org, which now points to
    GitHub for downloads. The old URL returns 404, so every build takes
    the file from the fallback at bitcoincore.org.
    
    Take the GitHub tag archive instead. Its hash differs from the old
    tarball, so store it as qrencode-4.1.1-v2.tar.gz. The old file name
    keeps its old hash on the fallback and in the CI caches, so the
    release branches are not affected. This is the follow-up to #33577.
    3466040a93
  3. DrahtBot added the label Build system on Oct 24, 2026
  4. DrahtBot commented at 12:54 PM on October 24, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. maflcko commented at 9:55 AM on October 26, 2026: member

    Why is this needed? Also, seems risky to change this now, will the new gui need this even?

  6. maflcko closed this on Oct 26, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-26 15:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me