No description provided.
fix non-standard reason string in main.cpp #3666
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:scriptsig changing 1 files +1 −1-
Diapolo commented at 2:13 PM on February 13, 2014: none
-
fix non-standard reason string in main.cpp bbfce8a4c9
-
BitcoinPullTester commented at 2:48 PM on February 13, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/bbfce8a4c9e7541d06dcc857dd0a82ec14d92180 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
jgarzik commented at 2:52 PM on February 13, 2014: contributor
I cannot discern from your commit message, or the patch, why this is a "fix", or is needed at all.
-
Diapolo commented at 4:39 PM on February 13, 2014: none
-
petertodd commented at 4:56 AM on February 14, 2014: contributor
ACK
Good to be clear as to where the non-standardness is given scriptPubKeys are allowed to have non-standard pushdata's. If that changes in the future we can create an additional scriptPubKey-non-canonical-push message.
-
Diapolo commented at 9:50 PM on February 16, 2014: none
See above links, I just used the wording that WAS already used for the other reason strings... I don't claim there is a BIP for this :-P.
-
sipa commented at 11:17 PM on February 16, 2014: member
ACK
- laanwj referenced this in commit 047ee427e7 on Feb 17, 2014
- laanwj merged this on Feb 17, 2014
- laanwj closed this on Feb 17, 2014
- Diapolo deleted the branch on Feb 17, 2014
- DrahtBot locked this on Sep 8, 2021