fix non-standard reason string in main.cpp #3666

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:scriptsig changing 1 files +1 −1
  1. Diapolo commented at 2:13 PM on February 13, 2014: none

    No description provided.

  2. fix non-standard reason string in main.cpp bbfce8a4c9
  3. BitcoinPullTester commented at 2:48 PM on February 13, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/bbfce8a4c9e7541d06dcc857dd0a82ec14d92180 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. jgarzik commented at 2:52 PM on February 13, 2014: contributor

    I cannot discern from your commit message, or the patch, why this is a "fix", or is needed at all.

  5. laanwj commented at 7:23 PM on February 13, 2014: member

    @diaplo Can you link to the standard that would make this nonstandard? I cannot find any of these reasons in BIP0022 in a quick glance.

  6. petertodd commented at 4:56 AM on February 14, 2014: contributor

    ACK

    Good to be clear as to where the non-standardness is given scriptPubKeys are allowed to have non-standard pushdata's. If that changes in the future we can create an additional scriptPubKey-non-canonical-push message.

  7. Diapolo commented at 9:50 PM on February 16, 2014: none

    See above links, I just used the wording that WAS already used for the other reason strings... I don't claim there is a BIP for this :-P.

  8. sipa commented at 11:17 PM on February 16, 2014: member

    ACK

  9. laanwj referenced this in commit 047ee427e7 on Feb 17, 2014
  10. laanwj merged this on Feb 17, 2014
  11. laanwj closed this on Feb 17, 2014

  12. Diapolo deleted the branch on Feb 17, 2014
  13. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me