Add raw transaction hex to gettransaction wallet RPC #3668

1. 
   laanwj commented at 4:31 pm on February 13, 2014: member

   This allows getting raw transaction data from the wallet even if the transaction is no longer in the blockchain / mempool (for example if it got orphaned due to malleability abuse).

   Alternative to #3663

2. Add raw transaction hex to `gettransaction` wallet RPC

   This allows getting raw transaction data from the wallet even if the
   transaction is no longer in the blockchain / mempool (for example if it
   got orphaned due to malleability abuse).

   3a1c20b77a
3. 
   sipa commented at 4:32 pm on February 13, 2014: member

   It also adds support for getting the raw wallet transaction of confirmed transactions. Previously, that required txindex=1.
4. 
   jgarzik commented at 4:35 pm on February 13, 2014: contributor

   ACK
5. 
   BitcoinPullTester commented at 5:28 pm on February 13, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/3a1c20b77a610edf5d7e8b1e5cbd47062cae7fcd for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
6. laanwj referenced this in commit c46ad17785 on Feb 13, 2014
7. laanwj merged this on Feb 13, 2014
8. laanwj closed this on Feb 13, 2014

   ---

9. 
   sipa commented at 11:41 pm on February 16, 2014: member

   I think this serializes it as a CWalletTx, instead of as a CTransaction, so including all implementation-specific wallet metadata. Just judging by the code, I haven’t tested.
10. 
    laanwj commented at 7:55 am on February 17, 2014: member

    @sipa I only tested that decoderawtransaction works on the output. But it seems you are right, there is junk data after it. See #3690.
11. laanwj deleted the branch on Apr 9, 2014
12. DrahtBot locked this on Sep 8, 2021

Contributors
laanwj sipa jgarzik BitcoinPullTester