This allows getting raw transaction data from the wallet even if the transaction is no longer in the blockchain / mempool (for example if it got orphaned due to malleability abuse).
Alternative to #3663
Add raw transaction hex to `gettransaction` wallet RPC #3668
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_02_gettransaction_hex changing 1 files +7 −1-
laanwj commented at 4:31 PM on February 13, 2014: member
-
3a1c20b77a
Add raw transaction hex to `gettransaction` wallet RPC
This allows getting raw transaction data from the wallet even if the transaction is no longer in the blockchain / mempool (for example if it got orphaned due to malleability abuse).
-
sipa commented at 4:32 PM on February 13, 2014: member
It also adds support for getting the raw wallet transaction of confirmed transactions. Previously, that required txindex=1.
-
jgarzik commented at 4:35 PM on February 13, 2014: contributor
ACK
-
BitcoinPullTester commented at 5:28 PM on February 13, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/3a1c20b77a610edf5d7e8b1e5cbd47062cae7fcd for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- laanwj referenced this in commit c46ad17785 on Feb 13, 2014
- laanwj merged this on Feb 13, 2014
- laanwj closed this on Feb 13, 2014
-
sipa commented at 11:41 PM on February 16, 2014: member
I think this serializes it as a CWalletTx, instead of as a CTransaction, so including all implementation-specific wallet metadata. Just judging by the code, I haven't tested.
-
- laanwj deleted the branch on Apr 9, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors