On top of #36688, this fixes the remaining issue with urgent data on macOS / BSD platforms described here.
Besides Linux, i've tested this on macOS, BSD and Windows VMs.
net: in socket monitoring, only register the exception set on Windows #36711
pull darosior wants to merge 3 commits into bitcoin:master from darosior:2610_exceptions_winonly changing 3 files +49 −0-
darosior commented at 3:42 PM on October 30, 2026: member
-
23fe594b5b
net: receive TCP urgent data inline
Set SO_OOBINLINE on TCP sockets, to receive urgent data like any other data. Otherwise, recv() does not return it, while select() keeps reporting it as pending on some platforms.
-
qa: test TCP urgent data is received inline de87cb8407
-
sock: only register the exception set on Windows 7b2005457f
- DrahtBot added the label P2P on Oct 30, 2026
-
DrahtBot commented at 3:42 PM on October 30, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36711
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36711.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36711#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
- fanquake marked this as a draft on Oct 30, 2026
-
darosior commented at 5:52 PM on October 30, 2026: member
I think Cory is right, i'll close this for now.
- darosior closed this on Oct 30, 2026
Labels