contrib: pass windows codesigning passphrase via stdin #36722

pull Steeve-Crypto wants to merge 1 commits into bitcoin:master from Steeve-Crypto:windeploy-readpass-stdin changing 1 files +2 −1
  1. Steeve-Crypto commented at 4:54 AM on November 2, 2026: none

    osslsigncode -pass places the key passphrase in the process arguments, so ps can read it.

    So instead, pipe it to -readpass -, which reads it from stdin (osslsigncode 2.9+, the Guix codesign manifest uses 2.14). Since printf is a shell builtin, the passphrase does not appear in any process arguments.

    Only sh -n was used to verify, not actual signing keys. This focuses on the Windows part of #36651.

  2. contrib: pass windows codesigning passphrase via stdin
    osslsigncode -pass puts the key passphrase in the process arguments,
    where ps can read it. Pipe it to -readpass - instead, which reads it
    from stdin. printf is a shell builtin, so the passphrase does not
    appear in any process arguments.
    cb102c93ef
  3. DrahtBot added the label Scripts and tools on Nov 2, 2026
  4. DrahtBot commented at 4:54 AM on November 2, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. hebasto commented at 12:22 PM on November 2, 2026: member

    Concept ~0. See #36651 (comment).

    Since printf is a shell builtin...

    Are you sure this holds for all shells?

  6. achow101 commented at 4:00 AM on November 3, 2026: member

    Concept meh

    We assume that code signer machines are not compromised.

  7. Steeve-Crypto closed this on Nov 4, 2026

  8. Steeve-Crypto commented at 6:28 PM on November 4, 2026: none

    Thanks for the reviews, closing since the threat model doesn't justify it


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-16 00:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me