Problem: Wallet encryption ignores a failed database rewrite after encrypted key records have been committed. Old plaintext key material can remain in unused pages without a warning.
Fix: Log the cleanup failure while preserving the successful encryption result. The warning advises moving funds to a newly created wallet before relying on at-rest encryption.
Show that `EncryptWallet()` still returns true and leaves usable encrypted keys when the final database rewrite fails.
A successful rewrite is the control, and a TODO marks the missing warning for the following fix.
Encrypted key records have already been committed when the final database rewrite runs.
A failed rewrite can leave old plaintext key bytes in unused pages, so log a warning while keeping the successful encryption result.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
I prefer that we simply drop this code once encryptwallet is dropped altogether.
Or alternatively, we do a RAII thing that turns on/off secure_delete as needed, rather than requiring the caller to use VACUUM afterwards which can fail.
